Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Address deprecation warning when importing poetry.core.semver #106

Merged
merged 3 commits into from
Dec 23, 2022
Merged

fix: Address deprecation warning when importing poetry.core.semver #106

merged 3 commits into from
Dec 23, 2022

Conversation

edgarrmondragon
Copy link
Contributor

Addresses the warning

.../site-packages/poetry_dynamic_versioning/plugin.py:16: DeprecationWarning: poetry.core.semver is deprecated. Use poetry.core.constraints.version instead.
  from poetry.core.semver.version import Version as PoetryCoreVersion

@edgarrmondragon edgarrmondragon force-pushed the fix/deprecation-poetry.core.semver branch from fcc008c to 94b9237 Compare December 22, 2022 09:23
@edgarrmondragon edgarrmondragon marked this pull request as draft December 22, 2022 09:23
@edgarrmondragon edgarrmondragon marked this pull request as ready for review December 23, 2022 02:03
@mtkennerly mtkennerly added the bug Something isn't working label Dec 23, 2022
@mtkennerly mtkennerly added this to the v0.21.3 milestone Dec 23, 2022
mtkennerly
mtkennerly approved these changes Dec 23, 2022
View reviewed changes
Copy link
Owner

@mtkennerly mtkennerly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ❤️ I'll put out a new release shortly.

@mtkennerly mtkennerly merged commit 7caae67 into mtkennerly:master Dec 23, 2022
@edgarrmondragon edgarrmondragon deleted the fix/deprecation-poetry.core.semver branch December 23, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtkennerly mtkennerly mtkennerly approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.21.3
Development

Successfully merging this pull request may close these issues.
2 participants
@edgarrmondragon @mtkennerly