Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues when trying to configure the file paths to match with toml. #18

Merged
merged 1 commit into from
Aug 8, 2020

Conversation

mariusvniekerk
Copy link
Contributor

@mariusvniekerk mariusvniekerk commented Aug 7, 2020

Since Path.glob eventually interns the strings and file_glob here could be a <tomlkit.items.String> instead of <str> we need to just ensure that we pass a plain vanilla string to glob.

Since Path.glob eventually interns the strings and file_glob here could be
a <tomlkit.items.String> instead of <str> we need to just ensure that we
pass a plain vanilla string to glob.
@mtkennerly
Copy link
Owner

Thanks! I'm curious, how would you reproduce the issue that this was causing? I would be interested in adding a test for it, but I'm not clear on that part.

@mtkennerly mtkennerly merged commit 0f2db8a into mtkennerly:master Aug 8, 2020
@mariusvniekerk
Copy link
Contributor Author

Basically I set this

[tool.poetry-dynamic-versioning.substitution]
files = ['*.py', '*/__init__.py', '*/__version__.py', '*/_version.py', '*/meta.yaml']
patterns = [
    "(^__version__\\s*=\\s*['\"])[^'\"]*(['\"])",
    '(^.*version:\s*:)^$.(.*)'
]

in my pyproject.toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants