Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Pathlib object #41

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Ensure Pathlib object #41

merged 1 commit into from
Mar 5, 2021

Conversation

cburgess
Copy link
Contributor

@cburgess cburgess commented Mar 5, 2021

Sometimes we get a string instead of a pathlib objects.

Fixes: #40

Sometimes we get a string instead of a pathlib objects.

Fixes: mtkennerly#40
@cburgess
Copy link
Contributor Author

cburgess commented Mar 5, 2021

I will confess that I did not get the pre-commit or integration hooks functioning before submitting this PR. They produces a number of errors when attempting to run on my MacOS BigSur install. Given how simple the fix is I decided not to bother trying to make all the tests function on BigSur, but I totally understand if you want to close this PR and open one you create yourself with all the pre-commit hooks and tests functional.

Copy link
Owner

@mtkennerly mtkennerly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! The pre-commit/test checks in the GitHub workflow all passed fine, so no worries there :D

@mtkennerly mtkennerly added this to the v0.12.4 milestone Mar 5, 2021
@mtkennerly mtkennerly merged commit e6f9b02 into mtkennerly:master Mar 5, 2021
@mtkennerly mtkennerly added the bug Something isn't working label Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues trying to run with tox poetry helpers
2 participants