Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add import for python-crypotgraphy >= 43.0.0 #407

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

arkamar
Copy link
Contributor

@arkamar arkamar commented Sep 1, 2024

write_pkcs12_container method raises following error message with python-cryptography-43.0.0:

Error: module 'cryptography.hazmat.primitives.serialization' has no attribute 'pkcs12'

Explicit import of the pkcs12 module resolves the issue.


I am not sure what exactly causes the issue, I couldn't spot it in python-cryptography 42.0.8..43.0.0 diff.

write_pkcs12_container method raises following error message with
python-cryptography-43.0.0:

  Error: module 'cryptography.hazmat.primitives.serialization' has no attribute 'pkcs12'

Explicit import of the pkcs12 module resolves the issue.
@olszomal
Copy link
Collaborator

olszomal commented Sep 2, 2024

LGTM

@mtrojnar mtrojnar merged commit 64305d6 into mtrojnar:master Sep 2, 2024
10 checks passed
@arkamar arkamar deleted the import-fix branch September 2, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants