Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gulp jshint.js #845

Closed
MartyIX opened this issue Jun 14, 2015 · 5 comments
Closed

gulp jshint.js #845

MartyIX opened this issue Jun 14, 2015 · 5 comments
Labels
docs Improvements or additions to the documentation

Comments

@MartyIX
Copy link

MartyIX commented Jun 14, 2015

Hi,

I needed to change

  '../node_modules/.bin/jsxhint --harmony "../src/**" "./src/app/**" --exclude ../src/utils/modernizr.custom.js'

to

  '"../node_modules/.bin/jsxhint" --harmony "../src/**" "./src/app/**" --exclude ../src/utils/modernizr.custom.js'

in https://github.com/callemall/material-ui/blob/master/docs/gulp/tasks/jshint.js to make the gulp task work on my Windows box (Win8.1).

I'm not sure if it is really a bug or not. If it is not, please close the issue.
This was referenced Jun 15, 2015
Merged
Closed
@pomerantsev
Copy link
Contributor

Interesting. @MartyIX can you submit a PR? I have recently got a Windows machine, but it'll take me some time to set up a development environment there so I can test this fix.

@MartyIX
Copy link
Author

MartyIX commented Jun 16, 2015

I see the issue fixed in https://github.com/callemall/material-ui/pull/846/files

I do not know if the fix works on all platforms. I just know that it fixes my problem on Windows.

@chrismcv
Copy link
Contributor

i've run windows in the office, and linux at home... both are good, so i'm assuming osx is ok...

@pomerantsev
Copy link
Contributor

Thank you, @chrismcv. I confirm that osx is okay.

@hai-cea
Copy link
Member

hai-cea commented Jun 19, 2015

Thanks everyone. Closing since it was fixed in #846

@hai-cea hai-cea closed this as completed Jun 19, 2015
@hai-cea hai-cea mentioned this issue Jun 19, 2015
Closed
mnajdova pushed a commit to mnajdova/material-ui that referenced this issue Nov 10, 2020
@dmtrKovalenko
[UX] Fix flickering date-time picker on changing date/time labels fro…
ad0a427 
…m narrow to wide (mui#845)

* Make dialog height consistent when tabs showing

* Remove more unused prop-types

* Fix flickering on moving from narrow to wide date label

* Fix flickering for datetime picker time part

* Fix ModalWrapper unit tests
@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 25, 2022
@zannager zannager added docs Improvements or additions to the documentation and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 13, 2023
@snyk-bot snyk-bot mentioned this issue Apr 12, 2023
Open
@zhaleTaheri zhaleTaheri mentioned this issue Nov 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@chrismcv @MartyIX @hai-cea @oliviertassinari @pomerantsev @zannager