[CheckBox] Add new colors to the Checkbox and IconButton #19164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r3dm1ke
changed the title
|
@material-ui/core: parsed: +0.37% , gzip: +0.18% Details of bundle changes.Comparing: e5b2e22...69d0911
|
|
I don't think that our style infrastructure is ready for pushing this approach further. Thanks for the exploration. |
1 task
zannager
added
the
component: checkbox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support for
success,infoandwarningcolors for theCheckboxandIconButtoncomponents. Had to do both, b/cCheckboxrenders theIconButtonunder the hood and otherwise, it got type warnings. I started with theCheckboxcomponent as it is simple enough and can give insights on how to implement these colors for everything else.