Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Improve documentation of the system #23294

Merged
merged 90 commits into from
Nov 12, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
90 commits
Select commit Hold shift + click to select a range
eb5426b
wip
mnajdova Oct 28, 2020
4cc8ceb
finished doc page
mnajdova Oct 28, 2020
4ce7687
typos
mnajdova Oct 28, 2020
e99de3b
docs:i18n & docs:typescript:formatted
mnajdova Oct 28, 2020
cae9761
fixes
mnajdova Oct 28, 2020
54d8a55
Update docs/src/pages/system/sx/sx.md
mnajdova Oct 28, 2020
b8fb9dd
Update docs/src/pages/system/sx/sx.md
mnajdova Oct 28, 2020
9b56867
Update docs/src/pages.js
mnajdova Oct 28, 2020
e5978a4
Update docs/translations/translations.json
mnajdova Oct 28, 2020
d99cf00
Update docs/src/pages/system/sx/sx.md
mnajdova Oct 28, 2020
c94ca93
Update docs/src/pages/system/sx/BreakpointsAsArray.tsx
mnajdova Oct 28, 2020
79a7d8b
Update docs/src/pages/system/sx/BreakpointsAsObject.js
mnajdova Oct 28, 2020
e07060a
Update docs/src/pages/system/sx/BreakpointsAsArray.js
mnajdova Oct 28, 2020
acbc866
Update docs/src/pages/system/sx/BreakpointsAsObject.tsx
mnajdova Oct 28, 2020
e2652f9
Update docs/src/pages/system/sx/GettingStarted.js
mnajdova Oct 28, 2020
a1bafa7
Update docs/src/pages/system/sx/GettingStarted.tsx
mnajdova Oct 28, 2020
f8e965d
Update docs/src/pages/system/sx/ValueAsFunction.js
mnajdova Oct 28, 2020
aa081b8
Update docs/src/pages/system/sx/ValueAsFunction.tsx
mnajdova Oct 28, 2020
b30e24b
Update docs/src/pages/system/sx/sx.md
mnajdova Oct 28, 2020
14a908c
Update docs/src/pages/system/sx/sx.md
mnajdova Oct 28, 2020
c029718
Update docs/src/pages/system/sx/sx.md
mnajdova Oct 28, 2020
682a5a8
Update docs/src/pages/system/sx/sx.md
mnajdova Oct 28, 2020
cb867a9
Update docs/src/pages/system/sx/sx.md
mnajdova Oct 28, 2020
52720d5
Update docs/src/pages/system/sx/sx.md
mnajdova Oct 28, 2020
dbd5026
Update docs/src/pages/system/sx/sx.md
mnajdova Oct 28, 2020
35fe80e
Update docs/src/pages/system/sx/sx.md
mnajdova Oct 28, 2020
c6a8d46
converted border demos
mnajdova Nov 1, 2020
7fc6a78
Merge branch 'feat/sx-prop-docs-page' of https://github.com/mnajdova/…
mnajdova Nov 1, 2020
d909c63
displays examples converted
mnajdova Nov 2, 2020
a19edd6
Merge branch 'next' into feat/sx-prop-docs-page
mnajdova Nov 3, 2020
e28a683
addressing comments
mnajdova Nov 3, 2020
87c118e
prettier & interface
mnajdova Nov 3, 2020
b0fa09c
demo update
mnajdova Nov 5, 2020
e3808bb
wip update content
mnajdova Nov 5, 2020
01bc241
Updated docs
mnajdova Nov 5, 2020
780d5fd
Update packages/material-ui/src/Box/index.js
mnajdova Nov 5, 2020
cc5f8c7
Update docs/translations/translations.json
mnajdova Nov 5, 2020
6a9108d
Update packages/material-ui/src/Box/styleFunction.d.ts
mnajdova Nov 5, 2020
9d5bd14
Update packages/material-ui/src/Box/styleFunction.js
mnajdova Nov 5, 2020
2854661
Update packages/material-ui/src/Box/styleFunction.js
mnajdova Nov 5, 2020
8b7ea10
Update packages/material-ui/src/Box/styleFunction.js
mnajdova Nov 5, 2020
a34ae16
Update packages/material-ui/src/styles/experimentalStyled.js
mnajdova Nov 5, 2020
8c5823a
one-liner
oliviertassinari Nov 5, 2020
d50a6af
update header
oliviertassinari Nov 5, 2020
28eb893
formatted
mnajdova Nov 5, 2020
b198753
updated demo
mnajdova Nov 5, 2020
6a8b944
Update docs/src/pages/system/basics/basics.md
mnajdova Nov 5, 2020
64b51cc
Update docs/src/pages/system/basics/basics.md
mnajdova Nov 5, 2020
47af380
Update docs/src/pages/system/basics/basics.md
mnajdova Nov 5, 2020
18752f5
Update docs/src/pages/system/basics/basics.md
mnajdova Nov 5, 2020
541d0b7
polish
oliviertassinari Nov 5, 2020
af31b6c
Update docs/src/pages/system/basics/Demo.js
mnajdova Nov 6, 2020
a9ca97f
Merge pull request #14 from oliviertassinari/polish-demo
mnajdova Nov 6, 2020
dd7b9fa
Update docs/src/pages/system/basics/basics.md
mnajdova Nov 6, 2020
5796085
Update docs/src/pages/system/basics/basics.md
mnajdova Nov 6, 2020
34c4309
Update docs/src/pages/system/basics/basics.md
mnajdova Nov 6, 2020
304116c
Update docs/src/pages/system/basics/basics.md
mnajdova Nov 6, 2020
faee8de
Update docs/src/pages/system/basics/basics.md
mnajdova Nov 6, 2020
71575b8
Update docs/src/pages/system/basics/basics.md
mnajdova Nov 6, 2020
584b289
Update docs/src/pages/system/basics/basics.md
mnajdova Nov 6, 2020
602d1d7
Update docs/src/pages/system/basics/basics.md
mnajdova Nov 6, 2020
153a18d
Update docs/src/pages/system/basics/basics.md
mnajdova Nov 6, 2020
6d66c80
Update docs/src/pages/system/basics/basics.md
mnajdova Nov 6, 2020
16a1c95
Update docs/src/pages/system/basics/basics.md
mnajdova Nov 6, 2020
357f73e
switching context demo
mnajdova Nov 6, 2020
b824976
fixed duplicated section
mnajdova Nov 6, 2020
6a4630b
prettier & formatted
mnajdova Nov 6, 2020
3101abd
improve-why
oliviertassinari Nov 6, 2020
9187099
review
mbrookes Nov 7, 2020
90ba086
improve last argument wording
oliviertassinari Nov 7, 2020
0b0670c
review
mbrookes Nov 7, 2020
40fe4a7
polish
oliviertassinari Nov 7, 2020
cffb670
more polish
oliviertassinari Nov 7, 2020
725c552
prefer the object by default over array
oliviertassinari Nov 7, 2020
c0f2269
marked token are wrong, we could consider using reactjs.org approach …
oliviertassinari Nov 7, 2020
5514a6b
add a note about performance
oliviertassinari Nov 7, 2020
5e7fa1a
Update docs/src/pages/system/basics/basics.md
mnajdova Nov 7, 2020
873490d
Update docs/src/pages/system/basics/basics.md
mnajdova Nov 7, 2020
fb42502
Update docs/src/pages/system/basics/basics.md
mnajdova Nov 7, 2020
cb35c1e
comments
mnajdova Nov 9, 2020
0f9a565
Update docs/src/pages/system/basics/basics.md
mnajdova Nov 9, 2020
6d1c063
Update docs/src/pages/system/basics/basics.md
mnajdova Nov 9, 2020
05b40fd
feedback
mnajdova Nov 9, 2020
efab4f0
Merge branch 'feat/sx-prop-docs-page' of https://github.com/mnajdova/…
mnajdova Nov 9, 2020
762b4cc
make the link clear
oliviertassinari Nov 9, 2020
5924891
Merge branch 'next' into feat/sx-prop-docs-page
mnajdova Nov 11, 2020
2ad356c
typos and final fixes
mnajdova Nov 11, 2020
6007e3b
test preview
mnajdova Nov 11, 2020
da64fea
Merge remote-tracking branch 'upstream/next' into feat/sx-prop-docs-page
eps1lon Nov 12, 2020
5aa6192
Remove prettier-ignore directives from user-facing code
eps1lon Nov 12, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
180 changes: 31 additions & 149 deletions benchmark/browser/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,163 +16,45 @@ You should use these numbers exclusively for comparing performance between diffe
yarn benchmark:browser

noop (baseline):

20.10ms
20.05ms
19.28ms
19.64ms
20.96ms
18.80ms
18.39ms
20.38ms
18.85ms
18.99ms
mean: 4.70ms, median: 4.72ms
-------------
Avg: 19.55ms
Median: 19.46ms

styled-components Box + @material-ui/system:

184.17ms
161.51ms
168.84ms
165.21ms
163.43ms
158.10ms
158.81ms
297.91ms
161.25ms
158.87ms
React primitives:
mean: 68.89ms, median: 64.02ms
-------------
Avg: 177.81ms
Median: 162.47ms

styled-components Box + styled-system:

142.66ms
146.55ms
141.12ms
141.04ms
139.45ms
145.63ms
141.36ms
134.98ms
123.98ms
146.09ms
React components:
mean: 74.38ms, median: 74.46ms
-------------
Avg: 140.29ms
Median: 141.24ms

Box emotion:

143.21ms
135.28ms
122.53ms
124.80ms
143.69ms
147.81ms
138.16ms
124.55ms
140.32ms
157.74ms
Styled Material-UI:
mean: 109.73ms, median: 109.46ms
-------------
Avg: 137.81ms
Median: 139.24ms

Box @material-ui/styles:

146.16ms
131.37ms
139.43ms
158.55ms
149.54ms
131.81ms
134.84ms
151.08ms
152.30ms
130.69ms
Styled emotion:
mean: 102.59ms, median: 104.28ms
-------------
Avg: 142.58ms
Median: 142.79ms

Box styled-components:

145.59ms
150.12ms
179.04ms
169.63ms
148.21ms
155.55ms
182.55ms
170.04ms
153.14ms
148.92ms
Styled SC:
mean: 104.06ms, median: 102.67ms
-------------
Avg: 160.28ms
Median: 154.35ms

Basic styled-components box:

141.73ms
139.71ms
121.01ms
120.02ms
121.81ms
143.22ms
135.67ms
120.85ms
121.08ms
120.59ms
makeStyles:
mean: 93.81ms, median: 92.90ms
-------------
Avg: 128.57ms
Median: 121.44ms

Chakra-UI box component:

147.42ms
128.51ms
118.74ms
110.01ms
133.05ms
130.20ms
121.57ms
119.11ms
108.57ms
134.90ms
sx Material-UI box:
mean: 187.98ms, median: 188.77ms
-------------
Avg: 125.21ms
Median: 125.04ms

Theme-UI box sx prop:

165.02ms
141.07ms
139.19ms
185.45ms
166.16ms
138.83ms
140.56ms
139.02ms
179.26ms
165.58ms
Box Material-UI:
mean: 159.24ms, median: 157.90ms
-------------
Avg: 156.01ms
Median: 153.05ms

Theme-UI div sx prop:

131.07ms
130.84ms
130.99ms
132.66ms
132.24ms
130.89ms
131.11ms
167.10ms
154.42ms
131.48ms
sx Theme-UI box:
mean: 164.22ms, median: 164.16ms
-------------
sx Theme-UI div:
mean: 153.10ms, median: 152.77ms
-------------
Box Chakra-UI:
mean: 154.95ms, median: 153.89ms
-------------
styled-components Box + @material-ui/system:
mean: 176.82ms, median: 176.60ms
-------------
styled-components Box + styled-system:
mean: 155.18ms, median: 154.63ms
-------------
Avg: 137.28ms
Median: 131.30ms
Done in 31.83s.
```
18 changes: 8 additions & 10 deletions benchmark/browser/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const Component = requirePerfScenarios(scenarioSuitePath).default;
const start = performance.now();
let end;

function TestCase(props) {
function Measure(props) {
const ref = React.useRef(null);

React.useLayoutEffect(() => {
Expand All @@ -28,20 +28,18 @@ function TestCase(props) {
};
});

return (
<React.Profiler id={scenarioSuitePath} onRender={logReactMetrics}>
<div ref={ref}>{props.children}</div>
</React.Profiler>
);
return <div ref={ref}>{props.children}</div>;
}

TestCase.propTypes = {
Measure.propTypes = {
children: PropTypes.node,
};

ReactDOM.render(
<TestCase>
<Component />
</TestCase>,
<React.Profiler id={scenarioSuitePath} onRender={logReactMetrics}>
<Measure>
<Component />
</Measure>
</React.Profiler>,
rootEl,
);
27 changes: 0 additions & 27 deletions benchmark/browser/scenarios/basic-styled-components/index.js

This file was deleted.

27 changes: 12 additions & 15 deletions benchmark/browser/scenarios/box-chakra-ui/index.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,11 @@
import * as React from 'react';
import { Box, ThemeProvider, theme } from '@chakra-ui/core';
import { Box, ThemeProvider } from '@chakra-ui/core';

// Let's say you want to add custom colors
const customTheme = {
...theme,
colors: {
...theme.colors,
brand: {
900: '#1a365d',
800: '#153e75',
700: '#2a69ac',
},
text: '#000',
background: '#fff',
primary: '#33e',
},
};

Expand All @@ -19,13 +14,15 @@ export default function BoxChakraUi() {
<ThemeProvider theme={customTheme}>
{new Array(1000).fill().map(() => (
<Box
color="primary.main"
bg="background.paper"
fontWeight="semibold"
fontSize={['30em', '48em', '62em', '80em']}
p={[2, 3, 4]}
width={200}
height={200}
color={'primary'}
backgroundColor={['primary', 'text', 'background']}
borderWidth={'3px'}
borderColor={'white'}
borderStyle={['dashed', 'solid', 'dotted']}
>
chakra-ui
test case
</Box>
))}
</ThemeProvider>
Expand Down
26 changes: 0 additions & 26 deletions benchmark/browser/scenarios/box-emotion/index.js

This file was deleted.

27 changes: 12 additions & 15 deletions benchmark/browser/scenarios/box-material-ui-styles/index.js
Original file line number Diff line number Diff line change
@@ -1,24 +1,21 @@
import * as React from 'react';
import { createMuiTheme } from '@material-ui/core/styles';
import { ThemeProvider as StylesThemeProvider } from '@material-ui/styles';
import BoxStyles from '@material-ui/core/Box';

const materialSystemTheme = createMuiTheme();
import Box from '@material-ui/core/Box';

export default function BoxMaterialUIStyles() {
return (
<StylesThemeProvider theme={materialSystemTheme}>
<React.Fragment>
{new Array(1000).fill().map(() => (
<BoxStyles
color="primary.main"
bgcolor="background.paper"
fontFamily="h6.fontFamily"
fontSize={['h6.fontSize', 'h4.fontSize', 'h3.fontSize']}
p={[2, 3, 4]}
<Box
width={200}
height={200}
borderWidth="3px"
borderColor="white"
backgroundColor={{ sm: 'primary.main' }}
borderStyle={{ sm: 'dashed' }}
>
@material-ui/styles
</BoxStyles>
test case
</Box>
))}
</StylesThemeProvider>
</React.Fragment>
);
}
27 changes: 0 additions & 27 deletions benchmark/browser/scenarios/box-styled-components/index.js

This file was deleted.

Loading