[SvgIcon] Migrate to emotion #24506
Merged
[SvgIcon] Migrate to emotion #24506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@material-ui/core: parsed: +0.14% , gzip: +0.13% |
|
The visual changes seem expected. We are fixing regressions we had in the past. |
mnajdova
reviewed
Jan 20, 2021
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
mnajdova
reviewed
Jan 20, 2021
mnajdova
reviewed
Jan 20, 2021
mnajdova
reviewed
Jan 20, 2021
| @@ -217,6 +218,7 @@ function testThemeVariants(element, getOptions) { | |||
| } | |||
|
|
|||
| const fullSuite = { | |||
| componentProp: testComponentProp, | |||
There was a problem hiding this comment.
👍 I think I removed this in the first iteration with the Slider, but then we decided we should keep the prop. We may need to disable this next on some of the converted components tough..
There was a problem hiding this comment.
It could create a conflict with open PRs, yes.
mnajdova
reviewed
Jan 20, 2021
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
mnajdova
approved these changes
Jan 20, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One iteration on #24405. Took 31 min