-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Accordion] Allow to disable gutter/spacing #24532
[Accordion] Allow to disable gutter/spacing #24532
Conversation
@material-ui/core: parsed: +0.08% , gzip: +0.07% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/material-ui/src/AccordionDetails/AccordionDetails.d.ts
Outdated
Show resolved
Hide resolved
@TimonPllkrn Yes, I think that this is the behavior that makes the most sense :). If you have ideas for improving the name of the prop, I would love to hear them. I also agree that it's confusing. The padding of the component should be easy enough to customize, I don't think that we need new dedicated props for them. Mind that the component is being migrated to emotion, I would encourage us to hold on until these pull requests are merged: I think that we can use this prop for this demo: https://next.material-ui.com/components/accordion/#customized-accordion, it simplifies it. |
@TimonPllkrn @oliviertassinari all PRs for migrating the Accordion components are merged. This work can continue :) |
@oliviertassinari I couldn't think of a better name either. I have now adapted the changes to the migration and added Also added the classes gutters and contentGutters to customize the style. |
35cee9f
to
3002532
Compare
30d4dc1
to
c0fe861
Compare
c0fe861
to
d275807
Compare
d275807
to
22e5c58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
resolves #24492
I've added the
disableGutters
prop to theAccordionSummary
andAccordionDetails
Components.