Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IconButton] Migrate to emotion #24542

Merged
merged 18 commits into from
Jan 23, 2021
Merged

[IconButton] Migrate to emotion #24542

merged 18 commits into from
Jan 23, 2021

Conversation

queengooborg
Copy link
Contributor

This PR migrates the IconButton component to the new emotion format as a part of #24405.

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 22, 2021 •
edited
Loading

@material-ui/core: parsed: +0.20% , gzip: +0.15%
@material-ui/lab: parsed: +0.19% , gzip: +0.19%

Details of bundle changes

Generated by 🚫 dangerJS against 5b76478

@github-actions github-actions bot mentioned this pull request Jan 22, 2021
Closed
@queengooborg
Copy link
Contributor Author

queengooborg commented Jan 22, 2021 •
edited
Loading

Hmm, CircleCI is having issues checking out PRs within the last 2 hours, so builds aren't passing... Doesn't look like it's specific to my PRs.

@oliviertassinari oliviertassinari mentioned this pull request Jan 22, 2021
Closed
@oliviertassinari oliviertassinari added the component: icon button This is the name of the generic UI component, not the React module! label Jan 22, 2021
queengooborg and others added 5 commits January 22, 2021 14:01
@queengooborg @oliviertassinari
Update packages/material-ui/src/IconButton/IconButton.js
4c9afa5 
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@queengooborg @oliviertassinari
Update packages/material-ui/src/IconButton/IconButton.js
f933c51 
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@queengooborg @oliviertassinari
Update packages/material-ui/src/IconButton/IconButton.js
d849539 
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@queengooborg
Merge branch 'next' into migrate/IconButton
04fef13
@queengooborg
Add missing variable
5b76478
@mnajdova mnajdova merged commit acb2e7d into mui:next Jan 23, 2021
@queengooborg queengooborg deleted the migrate/IconButton branch January 23, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
component: icon button This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@queengooborg @mui-pr-bot @oliviertassinari @mnajdova