Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hidden] Migrate to emotion #24544

Merged
merged 10 commits into from
Jan 25, 2021
Merged

[Hidden] Migrate to emotion #24544

merged 10 commits into from
Jan 25, 2021

Conversation

queengooborg
Copy link
Contributor

This PR migrates the Hidden component (specifically, HiddenCss) to the new emotion format as a part of #24405.

This component was very complex. I'm hoping I pulled it off properly!

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 22, 2021

@material-ui/core: parsed: +0.12% , gzip: +0.13%

Details of bundle changes

Generated by 🚫 dangerJS against f6bc767

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a first round of review. Will do another one after these comments are resolved :)

packages/material-ui/src/Hidden/HiddenCss.test.js Outdated Show resolved Hide resolved
packages/material-ui/src/Hidden/HiddenCss.js Outdated Show resolved Hide resolved
packages/material-ui/src/Hidden/HiddenCss.js Outdated Show resolved Hide resolved
packages/material-ui/src/Hidden/HiddenCss.js Outdated Show resolved Hide resolved
packages/material-ui/src/Hidden/HiddenCss.js Outdated Show resolved Hide resolved
@mnajdova mnajdova added the component: Hidden The React component. label Jan 23, 2021
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we needed to migrate it as we want to remove the components but it looks great :)

@mnajdova mnajdova merged commit 11efc56 into mui:next Jan 25, 2021
@queengooborg queengooborg deleted the migrate/Hidden branch January 25, 2021 06:58
natac13 pushed a commit to natac13/material-ui that referenced this pull request Jan 25, 2021
eps1lon pushed a commit to eps1lon/material-ui that referenced this pull request Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Hidden The React component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants