Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BottomNavigation] Migrate to emotion #24556

Merged
merged 16 commits into from
Jan 25, 2021

Conversation

queengooborg
Copy link
Contributor

This PR migrates the BottomNavigation and BottomNavigationAction components to the new emotion format as a part of #24405.

Notice: there's actually quite a number of failing builds for this one, such as with the docs generation. Hoping to get some feedback on how to resolve said issues.

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 23, 2021

@material-ui/core: parsed: +0.29% , gzip: +0.17%

Details of bundle changes

Generated by 🚫 dangerJS against c666b95

@mnajdova mnajdova changed the title [BottomNavigation] Migrate BottomNavigation[Action] to emotion [BottomNavigation] Migrate BottomNavigationAction to emotion Jan 23, 2021
@mnajdova mnajdova added the component: bottom navigation This is the name of the generic UI component, not the React module! label Jan 23, 2021
@queengooborg queengooborg changed the title [BottomNavigation] Migrate BottomNavigationAction to emotion [BottomNavigation] Migrate BottomNavigation and BottomNavigationAction to emotion Jan 23, 2021
@oliviertassinari oliviertassinari changed the title [BottomNavigation] Migrate BottomNavigation and BottomNavigationAction to emotion [BottomNavigation] Migrate to emotion Jan 23, 2021
@mnajdova mnajdova merged commit 2335e81 into mui:next Jan 25, 2021
natac13 pushed a commit to natac13/material-ui that referenced this pull request Jan 25, 2021
@queengooborg queengooborg deleted the migrate/BottomNavigation branch January 25, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: bottom navigation This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants