Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[List] Migrate ListItemText to emotion #24602

Merged
merged 20 commits into from
Jan 25, 2021
Merged

[List] Migrate ListItemText to emotion #24602

merged 20 commits into from
Jan 25, 2021

Conversation

natac13
Copy link
Contributor

@natac13 natac13 commented Jan 24, 2021

3 tests are still failing... 😞

#24405

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 24, 2021 •
edited
Loading

@material-ui/core: parsed: +0.17% , gzip: +0.14%

Details of bundle changes

Generated by 🚫 dangerJS against 1e27d02

@oliviertassinari oliviertassinari changed the title [ListItemText] Migrate to emotion [List] Migrate ListItemText to emotion Jan 24, 2021
@oliviertassinari oliviertassinari added the component: list This is the name of the generic UI component, not the React module! label Jan 24, 2021
@oliviertassinari oliviertassinari mentioned this pull request Jan 24, 2021
Closed
@oliviertassinari
Copy link
Member

@natac13 Could you look into the failing test case?

@mnajdova
Copy link
Member

3 tests are still failing... 😞

@natac13 there was a type on the overridesResolver - see 811427d

@natac13
Copy link
Contributor Author

natac13 commented Jan 25, 2021

Thank you, sorry I was not able to see it. I did get the muiName typo but you beat me to it. lol

I'll pick another component and try again.

@mnajdova
Copy link
Member

mnajdova commented Jan 25, 2021 •
edited
Loading

Thank you, sorry I was not able to see it. I did get the muiName typo but you beat me to it. lol

No worries, took me some time to see the typo too :)

@github-actions github-actions bot mentioned this pull request Jan 25, 2021
Closed
@mnajdova mnajdova merged commit 2a0a58e into mui:next Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees

@mnajdova mnajdova

Labels
component: list This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@natac13 @mui-pr-bot @oliviertassinari @mnajdova