Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ImageList] Migrate ImageListItem to emotion #24619

Merged
merged 10 commits into from
Jan 27, 2021
Merged

[ImageList] Migrate ImageListItem to emotion #24619

merged 10 commits into from
Jan 27, 2021

Conversation

kodai3
Copy link
Contributor

@kodai3 kodai3 commented Jan 25, 2021 •
edited
Loading

This PR migrates the ImageListItem component to the new emotion format as a part of #24405.

Because classes props was not in ImageListItem.d.ts, it was delete by running yarn proptypes. Should I fix this here?

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 25, 2021 •
edited
Loading

@material-ui/core: parsed: +0.15% , gzip: +0.08%

Details of bundle changes

Generated by 🚫 dangerJS against 31e9665

@oliviertassinari oliviertassinari added the component: image list This is the name of the generic UI component, not the React module! label Jan 25, 2021
@oliviertassinari oliviertassinari changed the title [ImageListItem] Migrate to emotion [ImageList] Migrate ImageListItem to emotion Jan 25, 2021
@oliviertassinari oliviertassinari mentioned this pull request Jan 25, 2021
Closed
@github-actions github-actions bot mentioned this pull request Jan 25, 2021
Closed
@mnajdova
Copy link
Member

Because classes props was not in ImageListItem.d.ts, it was delete by running yarn proptypes. Should I fix this here?

I've fixed this, thanks for pointing out. Also noticed that we were missing some of the overrides. Everything should be fixed now..

mnajdova
mnajdova approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mnajdova mnajdova merged commit 1864fcd into mui:next Jan 27, 2021
xs9627 added a commit to xs9627/material-ui that referenced this pull request Jan 27, 2021
@xs9627
Merge branch 'next' into migrate/MenuItem
8324055 
* next: (34 commits)
  [Tab] Migrate to emotion (mui#24651)
  [TextField] Migrate Input component to emotion (mui#24638)
  [ImageList] Migrate ImageListItemBar to emotion (mui#24632)
  [CircularProgress] Migrate to emotion (mui#24622)
  [DataTable] Add example in docs for data table (mui#24428)
  [Card] Migrate CardActionArea to emotion (mui#24636)
  [core] Fix `next` using stale pages (mui#24635)
  [List] Migrate ListItemIcon to emotion (mui#24630)
  [ClickAwayListener] Fix `children` and `onClickAway` types (mui#24565)
  [docs] Include in docs directive to silence `eslint` erroneous warning (mui#24644)
  [Fab] Migrate to emotion (mui#24618)
  [TextField] Migrate FilledInput to emotion (mui#24634)
  [Card] Migrate CardHeader to emotion (mui#24626)
  [Card] Migrate CardMedia to emotion (mui#24625)
  [ImageList] Migrate ImageListItem to emotion (mui#24619)
  [website] Add vision block (mui#24603)
  [docs] Add sorting section (mui#24637)
  [TextField] Prepare removal of labelWidth prop (mui#24595)
  [Dialog] Migrate DialogTitle to emotion (mui#24623)
  [ImageList] Migrate to emotion (mui#24615)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
component: image list This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kodai3 @mui-pr-bot @mnajdova @oliviertassinari