[TextField] Migrate OutlinedInput to emotion #24688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@material-ui/core: parsed: +0.08% , gzip: +0.08% |
oliviertassinari
added
the
component: text field
duganbrett
commented
Jan 30, 2021
mnajdova
reviewed
Feb 13, 2021
| @@ -130,11 +173,7 @@ const OutlinedInput = React.forwardRef(function OutlinedInput(props, ref) { | |||
| } | |||
| /> | |||
| )} | |||
| classes={{ | |||
| ...classes, | |||
| root: clsx(classes.root, classes.underline), | |||
There was a problem hiding this comment.
You missed the underline classes in the useUtilityClasses above
There was a problem hiding this comment.
It's been a while since I looked at this but I assumed this was here as an error. This shouldn't have an underline class.
github-actions
bot
added
the
PR: out-of-date
duganbrett
force-pushed
the
migrate-outlined-input
branch
from
f9fe959
to
7137c95
Compare
github-actions
bot
removed
the
PR: out-of-date
duganbrett
force-pushed
the
migrate-outlined-input
branch
from
36e1446
to
ade290b
Compare
tchock
added a commit
to Bojagi/material-ui
that referenced
this pull request
Feb 16, 2021
This is a copy of upstream PR mui#24688
tchock
added a commit
to Bojagi/material-ui
that referenced
this pull request
Feb 16, 2021
This is a copy of upstream PR mui#24688
tchock
added a commit
to Bojagi/material-ui
that referenced
this pull request
Feb 16, 2021
This is a copy of upstream PR mui#24688
oliviertassinari
force-pushed
the
migrate-outlined-input
branch
from
9e9bcb9
to
a7541b2
Compare
|
@duganbrett Thanks! |
tchock
added a commit
to Bojagi/material-ui
that referenced
this pull request
Mar 10, 2021
This is a copy of upstream PR mui#24688
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the OutlinedInput component to the new emotion format as a part of #24405.