Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ButtonGroup] Migrate ButtonGroup to emotion #24775

Merged
merged 5 commits into from
Feb 9, 2021
Merged

[ButtonGroup] Migrate ButtonGroup to emotion #24775

merged 5 commits into from
Feb 9, 2021

Conversation

mirefly
Copy link
Contributor

@mirefly mirefly commented Feb 5, 2021

part of #24405

@mui-pr-bot
Copy link

mui-pr-bot commented Feb 5, 2021 •
edited
Loading

@material-ui/core: parsed: +0.32% , gzip: +0.13%

Details of bundle changes

Generated by 🚫 dangerJS against 28ad2ef

@mirefly mirefly force-pushed the migrate-to-emotion-button-group branch from 3d26ec2 to d11d8c2 Compare February 5, 2021 05:30
@github-actions github-actions bot mentioned this pull request Feb 5, 2021
Closed
@mirefly mirefly force-pushed the migrate-to-emotion-button-group branch 4 times, most recently from 3f363bd to ac90fff Compare February 5, 2021 20:55
@mirefly mirefly force-pushed the migrate-to-emotion-button-group branch from ac90fff to 97d7160 Compare February 6, 2021 01:47
@mirefly
Copy link
Contributor Author

mirefly commented Feb 8, 2021

Thanks for reviewing it. I pushed the updates.

@mirefly mirefly force-pushed the migrate-to-emotion-button-group branch from 527268f to 93a9e29 Compare February 8, 2021 02:46
@oliviertassinari oliviertassinari self-assigned this Feb 8, 2021
@oliviertassinari oliviertassinari added component: button This is the name of the generic UI component, not the React module! component: ButtonGroup The React component. and removed component: button This is the name of the generic UI component, not the React module! labels Feb 8, 2021
@oliviertassinari oliviertassinari removed their assignment Feb 9, 2021
@oliviertassinari oliviertassinari merged commit b8c6dee into mui:next Feb 9, 2021
@oliviertassinari oliviertassinari mentioned this pull request Feb 9, 2021
Closed
@ZeeshanTamboli ZeeshanTamboli mentioned this pull request Nov 3, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova left review comments

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: ButtonGroup The React component.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mirefly @mui-pr-bot @oliviertassinari @mnajdova