Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rating] Migrate to emotion #25588

Merged
merged 11 commits into from
Apr 7, 2021
Merged

Conversation

natac13
Copy link
Contributor

@natac13 natac13 commented Apr 3, 2021

  • Beginning of Rating conversion
  • feat: finish Rating conversion to emotion

One chunk of #24405

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 3, 2021

Details of bundle changes

@material-ui/core: parsed: +0.36% , gzip: +0.29%
@material-ui/lab: parsed: +0.44% , gzip: +0.31%

Generated by 🚫 dangerJS against a2adea0

@oliviertassinari oliviertassinari added the component: rating This is the name of the generic UI component, not the React module! label Apr 4, 2021
packages/material-ui/src/Rating/Rating.js Outdated Show resolved Hide resolved
packages/material-ui/src/Rating/Rating.js Outdated Show resolved Hide resolved
packages/material-ui/src/Rating/Rating.js Outdated Show resolved Hide resolved
packages/material-ui/src/Rating/Rating.js Outdated Show resolved Hide resolved
@mnajdova mnajdova merged commit f44a170 into mui:next Apr 7, 2021
opacity: theme.palette.action.disabledOpacity,
pointerEvents: 'none',
},
[`&.Mui-focusVisible ${ratingClasses.iconActive}`]: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is broken:

Suggested change
[`&.Mui-focusVisible ${ratingClasses.iconActive}`]: {
[`&.Mui-focusVisible .${ratingClasses.iconActive}`]: {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: rating This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants