Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stepper] Migrate MobileStepper to emotion #25589

Merged
merged 8 commits into from
Apr 6, 2021
Merged

[Stepper] Migrate MobileStepper to emotion #25589

merged 8 commits into from
Apr 6, 2021

Conversation

natac13
Copy link
Contributor

@natac13 natac13 commented Apr 3, 2021 •
edited by oliviertassinari
Loading

One chunk of #24405

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 3, 2021 •
edited
Loading

Details of bundle changes

@material-ui/core: parsed: +0.24% , gzip: +0.18%

Generated by 🚫 dangerJS against 976f53c

@github-actions github-actions bot mentioned this pull request Apr 3, 2021
Closed
@oliviertassinari oliviertassinari changed the title [MobileStepper] Migrate to emotion [Stepper] Migrate MobileStepper to emotion Apr 4, 2021
@oliviertassinari oliviertassinari added the component: stepper This is the name of the generic UI component, not the React module! label Apr 4, 2021
@oliviertassinari oliviertassinari mentioned this pull request Apr 4, 2021
Closed
@natac13
fix: make suggested changes
4dd3755 
Fix the rename of slots
Add in the need style overrides
@natac13
fix: slot names
6753325
@natac13
Copy link
Contributor Author

natac13 commented Apr 5, 2021

Sorry @mnajdova, I cannot seem to figure out how to clear the few errors. I have tried the following, without much success.

Screen Shot 2021-04-05 at 16 25 02
Screen Shot 2021-04-05 at 16 26 59

@mnajdova
Copy link
Member

mnajdova commented Apr 5, 2021

Sorry @mnajdova, I cannot seem to figure out how to clear the few errors. I have tried the following, without much success.

Taking a look

@mnajdova
Copy link
Member

mnajdova commented Apr 5, 2021

The tests should be fixed by ddb207c the issues was that the dotActive is dynamic per dot, so we cannot use it in the useUtilityClasses.

mnajdova
mnajdova approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mnajdova mnajdova merged commit 0327bb3 into mui:next Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
component: stepper This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@natac13 @mui-pr-bot @mnajdova @oliviertassinari