-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Switch] Fix theme styleOverrides #25776
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some context why we need this change? Ideally with a test or codesandbox illustrating the issue.
@eps1lon I've linked the issue that this PR is solving |
@sparkpunk Could you run |
@eps1lon sure! |
I apologize, I spend more time on this issue, seems like in the original codesandbox, the import to the I am closing the issue and PR as it seems like everything is workingas expected, just by using the wrong provider, the incorrect context was changed. |
While this theme provider issue was a false-positive, the double root, doesn't seem to be one: We didn't use to forward the root directly (v4): |
Looks like regression comming from #24693 the classes object propagated to the |
Thanks @mnajdova! Can't believe it was an import error. D'oh. |
Fixes #25773