Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Migrate PickersDay to emotion #25995

Merged
merged 18 commits into from
May 11, 2021
Merged

[pickers] Migrate PickersDay to emotion #25995

merged 18 commits into from
May 11, 2021

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Apr 27, 2021 •
edited by oliviertassinari
Loading

One of #24405

@siriwatknp siriwatknp mentioned this pull request Apr 27, 2021
Closed
@mui-pr-bot
Copy link

mui-pr-bot commented Apr 27, 2021 •
edited
Loading

Details of bundle changes (experimental)

@material-ui/lab: parsed: +0.30% , gzip: +0.22%

Generated by 🚫 dangerJS against 6cb9abc

eps1lon
eps1lon requested changes Apr 27, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the original implementation logic. It should return different components not the same component with different props.

@github-actions github-actions bot mentioned this pull request Apr 28, 2021
Closed
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 28, 2021
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 28, 2021
@oliviertassinari oliviertassinari changed the title [Pickers] Migrate PickersDay to emotion [pickers] Migrate PickersDay to emotion Apr 28, 2021
@oliviertassinari oliviertassinari added the component: pickers This is the name of the generic UI component, not the React module! label Apr 28, 2021
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 29, 2021
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 29, 2021
siriwatknp and others added 2 commits April 30, 2021 08:14
@siriwatknp siriwatknp merged commit 68ea9e5 into mui:next May 11, 2021
@siriwatknp siriwatknp deleted the pickers-day-emotion branch May 11, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@siriwatknp @mui-pr-bot @mnajdova @eps1lon @oliviertassinari