Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Migrate ClockNumber to emotion #26058

Merged
merged 15 commits into from
May 13, 2021
Merged

[pickers] Migrate ClockNumber to emotion #26058

merged 15 commits into from
May 13, 2021

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp mentioned this pull request Apr 29, 2021
Closed
@mui-pr-bot
Copy link

mui-pr-bot commented Apr 29, 2021 •
edited
Loading

Details of bundle changes (experimental)

Generated by 🚫 dangerJS against fab7f9d

@oliviertassinari oliviertassinari added the component: pickers This is the name of the generic UI component, not the React module! label Apr 29, 2021
@oliviertassinari oliviertassinari changed the title [Pickers] Migrate ClockNumber to emotion [pickers] Migrate ClockNumber to emotion Apr 29, 2021
@mnajdova
Copy link
Member

@siriwatknp let's try to merge some of the open PRs before opening new ones

@siriwatknp
Copy link
Member Author

@siriwatknp let's try to merge some of the open PRs before opening new ones

okay, noted.

eps1lon
eps1lon requested changes Apr 30, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's resolve the existing ones first. The amount of boilerplate that is required for internal components is not ok.

@eps1lon eps1lon added the on hold There is a blocker, we need to wait label Apr 30, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented May 2, 2021 •
edited
Loading

required for internal components

The component isn't strictly speaking internal. The class names are public. Proof:

https://github.com/mui-org/material-ui/blob/36c1e08520f8add7bdc341825d44f50d59ceab83/packages/material-ui-lab/src/themeAugmentation/components.d.ts#L90-L92

@eps1lon
Copy link
Member

eps1lon commented May 2, 2021

The component isn't strictly speaking internal. The class names are public. Proof:

The API is there yes. But I consider them at this point internal since there's not documentation. Once pickers are in a presentable shape we can talk about customization. But right now it's not a concern worth debating over.

@github-actions github-actions bot mentioned this pull request May 2, 2021
Closed
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 5, 2021
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 10, 2021
@siriwatknp siriwatknp removed the on hold There is a blocker, we need to wait label May 12, 2021
@siriwatknp siriwatknp requested a review from eps1lon May 12, 2021 10:23
@siriwatknp siriwatknp merged commit 83d7f63 into mui:next May 13, 2021
@siriwatknp siriwatknp deleted the clock-number-emotion branch May 13, 2021 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@eps1lon eps1lon Awaiting requested review from eps1lon

Assignees
No one assigned
Labels
component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@siriwatknp @mui-pr-bot @mnajdova @oliviertassinari @eps1lon