[DateRangePicker] Migrate DateRangePickerDay to emotion #26368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Details of bundle changes (experimental) @material-ui/lab: parsed: +0.26% , gzip: +0.14% |
siriwatknp
commented
May 19, 2021
| styleProps.isHighlighting && { | ||
| color: theme.palette.getContrastText(alpha(theme.palette.primary.light, 0.6)), | ||
| }), | ||
| })) as unknown) as <TDate>( |
There was a problem hiding this comment.
unknown is needed for workaround with styleProps, otherwise got this error.
I think to improve this,
stylePropsinexperimental_styledshould be a generic with default type ofRecord<string, unknown>
mnajdova
reviewed
May 19, 2021
packages/material-ui-lab/src/DateRangePickerDay/DateRangePickerDay.test.tsx
Show resolved
Hide resolved
mnajdova
reviewed
May 20, 2021
packages/material-ui-lab/src/DateRangePickerDay/DateRangePickerDay.test.tsx
Show resolved
Hide resolved
mnajdova
reviewed
May 20, 2021
packages/material-ui-lab/src/DateRangePickerDay/DateRangePickerDay.tsx
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
May 20, 2021
packages/material-ui-lab/src/DateRangePickerDay/DateRangePickerDay.tsx
Outdated
Show resolved
Hide resolved
…/material-ui into date-range-picker-day-emotion
mnajdova
approved these changes
May 20, 2021
…te-range-picker-day-emotion
siriwatknp
added
the
component: date range picker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation on some points
need to case
unknowntoDateRangePickerDayDayto cast type toPickersDaybecause it needs to accept genericno need to use
useThemePropsin this component, sothemeDefaultPropsis skipped.I have followed (at least) the PR section of the contributing guide.