[Core] Remove style-propable mixin from transition-groups #2909
Conversation
newoga
added
PR: Needs Review
PR: needs revision
|
Don't merge this by the way. Think we should iron out some syntax details mentioned in #2907 before doing mass conversion away from style-propable. |
|
Once #3124 is merged, we can start again this PR. |
|
Yup, I have a few branches that started this. Looking forward to picking this back up. I also have a local branch that takes all the components that are using |
newoga
force-pushed
the
#2852-transition-groups
branch
from
8bf6114
to
d5fc7b4
Compare
newoga
added
PR: Needs Review
and removed
PR: needs revision
| @@ -91,8 +89,7 @@ const SlideIn = React.createClass({ | |||
|
|
|||
| return ( | |||
| <ReactTransitionGroup | |||
| {...other} | |||
There was a problem hiding this comment.
Thanks for the catch, that was not intentional 👍
|
I'm happy with it, I would say let's squash down and merge 🎉. |
This commit removes the `style-propable` mixin from `transition-groups` components. It replaces `this.mergeStyles()` with `Object.assign` and `this.prepareStyles()` with the same implementation that is stored in context. In addition, this commit replaces usage of `let` with `const` when the variable is not reassigned. Signed-off-by: Neil Gabbadon <neil.gabbadon@emikra.com>
newoga
force-pushed
the
#2852-transition-groups
branch
from
7467f54
to
91c12ea
Compare
|
Squashed here too! If all is green, feel free to merge 😄 |
|
@newoga Awesome, let's start the migration 🚜. |
[Core] Remove style-propable mixin from transition-groups
Yay, here we go! 🎉 🏃 |
I'm going to try my best to do this methodically.
Related to #2852.
Two of these components now no longer have mixins! Two of them use the PureRenderMixin. Do you think we should replace the PureRenderMixin with shallow-compare in preparation of moving these to classes?