[Core] Remove dependency on utils/styles from components #3169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: This should probably be merged after the merge of #3124. |
|
This is awesome 👍 👍 it gives us more ground to implement memoization later on. thanks @newoga 😁 |
|
@newoga Could you rebase? |
This commit removes the import of `mergeStyles` and `prepareStyles` from `utils/styles` for most components and files. The use of `mergeStyles` has been replaced with `Object.assign` and the `prepareStyles` function that is imported has been replaced with the `prepareStyles` implementation stored in context. As of this commit, there are only two files importing from `utils/styles`: 1. `menus/menu-divider.jsx` (which is planned for removal in PR mui#3108) 2. `mixins/style-propable.js` (which many components are still using, but the removal of this mixin is tracked in mui#2852) Signed-off-by: Neil Gabbadon <neil.gabbadon@emikra.com>
newoga
force-pushed
the
utils-styles-to-object-assign
branch
from
9e86063
to
3fa5894
Compare
|
Done! |
oliviertassinari
added a commit
that referenced
this pull request
Feb 4, 2016
[Core] Remove dependency on utils/styles from components
|
@newoga Looks good 🐎! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the import of
mergeStylesandprepareStylesfromutils/stylesfor most components and files. The use ofmergeStyleshas been replaced withObject.assignand theprepareStylesfunction that is imported has been replaced with theprepareStylesimplementation stored in context.As of this commit, there are only two files importing from
utils/styles:menus/menu-divider.jsx(which is planned for removal in PR [Core] Remove the deprecated API of v0.14.x #3108)mixins/style-propable.js(which many components are still using, but the removal of this mixin is tracked in [Core] remove style-propable mixin from components #2852)Signed-off-by: Neil Gabbadon neil.gabbadon@emikra.com