Bump @types/react to v18.2.45 #40146
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
Netlify deploy previewhttps://deploy-preview-40146--material-ui.netlify.app/ Bundle size report |
|
The issue regarding the removal of |
| NumberInputOwnerState | ||
| >; | ||
| export type NumberInputOwnProps = Omit<UseNumberInputParameters, 'error'> & | ||
| Pick<React.InputHTMLAttributes<HTMLInputElement>, 'placeholder'> & { |
There was a problem hiding this comment.
I wanted to add it to AdditionalProps in NumberInputTypeMap, but then it's not picked up for prop types generation. 🙈
Do you prefer manually documenting this prop instead, similar to error? 🤔
|
@mui/base-ui @mj12albert could you please review the proposed change and adjust if necessary? 🤔 |
github-actions
bot
added
the
PR: out-of-date
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/react-18.x
branch
from
d78402a
to
8b25138
Compare
github-actions
bot
removed
the
PR: out-of-date
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
|
@LukasTy Sorry I ticked the rebase checkbox and wiped out your changes 🙈 But I've inlined it back into |
There was a problem hiding this comment.
LukasTy Sorry I ticked the rebase checkbox and wiped out your changes 🙈
But I've inlined it back into
OwnPropsto keep it flatter looking 😬
No problem. 👌
LGTM.
Sure, whatever you think works best.
IMHO, placeholder prop is self explanatory and having it without JSDoc wouldn't hurt. However, extra clarity won't hurt. 👍
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Albert Yu <albert@albertyu.co>
This PR contains the following updates:
^18.2.42->^18.2.45Configuration
📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.