[styled-engine-sc][system] Use namespaced theme prop for css functions in styled-engine-sc #40656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-40656--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
delijah
changed the title
delijah
changed the title
delijah
changed the title
2 tasks
delijah
force-pushed
the
fix-styled-engine-sc-css-func-theme
branch
2 times, most recently
from
c19a06b
to
53adeaa
Compare
delijah
force-pushed
the
fix-styled-engine-sc-css-func-theme
branch
from
53adeaa
to
1b266c5
Compare
|
I will wait for #40690 before continuing this PR. |
github-actions
bot
added
the
PR: out-of-date
Actually this PR makes #40640 obsolete. My idea was to merge #40640 first (since it contains no breaking changes and is way simpler than this one) and then later this one. I guess this one needs some heavy refactoring after merging #40690? :) Should i try to do it, or do you want to do it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part 2 of #40140
Codesandbox: https://codesandbox.io/p/devbox/fix-styled-engine-sc-css-theme-object-lpkkcv?file=%2Fsrc%2FApp.tsx%3A11%2C1
This PR could probably be considered as a breaking change.