Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pigment][next] Warn about unsupported turbo mode in Next.js #41445

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

brijeshb42
Copy link
Contributor

@brijeshb42 brijeshb42 added the package: pigment-css Specific to @pigment-css/* label Mar 11, 2024
@mui-bot
Copy link

mui-bot commented Mar 11, 2024

Netlify deploy preview

https://deploy-preview-41445--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 12c84ae

@brijeshb42 brijeshb42 force-pushed the pigment/next-turbo-warn branch 2 times, most recently from 424a97a to 10230f9 Compare March 11, 2024 13:35
@samuelsycamore samuelsycamore changed the title [pigment][next] Warn about unsupported trubo mode in Next.js [pigment][next] Warn about unsupported turbo mode in Next.js Mar 11, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 12, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 12, 2024
@brijeshb42 brijeshb42 requested review from siriwatknp and removed request for mnajdova and siriwatknp March 12, 2024 14:52
const { babelOptions, asyncResolve, ...rest } = pigmentConfig;
export function withPigment(nextConfig: NextConfig, pigmentConfig?: PigmentOptions) {
const { babelOptions = {}, asyncResolve, ...rest } = pigmentConfig ?? {};
if (process.env.TURBOPACK === '1') {
Copy link
Member

@siriwatknp siriwatknp Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a link to where TURBOPACK is coming from? Would be nice to have a comment about this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's undocumented. I had to go through next.js code to find it.

@brijeshb42 brijeshb42 merged commit 5d2e45f into mui:master Mar 13, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: pigment-css Specific to @pigment-css/*
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants