Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Update the prettier script to use the next branch #41637

Merged
merged 14 commits into from
Mar 29, 2024

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova added the core Infrastructure work going on behind the scenes label Mar 25, 2024
@mui-bot
Copy link

mui-bot commented Mar 25, 2024

Netlify deploy preview

https://deploy-preview-41637--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 837f6d7

package.json Show resolved Hide resolved
Signed-off-by: Marija Najdova <mnajdova@gmail.com>
@mnajdova mnajdova mentioned this pull request Mar 25, 2024
1 task
package.json Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@mnajdova mnajdova changed the title [core] Change prettier to use the next branch [core] Change few CI scripts to use the next branch Mar 25, 2024
@mnajdova
Copy link
Member Author

Signed-off-by: Marija Najdova <mnajdova@gmail.com>
@mnajdova
Copy link
Member Author

@michaldudak created issue around the pnpm install issue - pnpm/pnpm#7823, no changes required on our end for that one.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 26, 2024
Signed-off-by: Marija Najdova <mnajdova@gmail.com>
.circleci/config.yml Outdated Show resolved Hide resolved
Signed-off-by: Marija Najdova <mnajdova@gmail.com>
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 26, 2024
@mnajdova mnajdova marked this pull request as ready for review March 26, 2024 12:12
@mnajdova mnajdova changed the title [core] Change few CI scripts to use the next branch [core] Update the prettier script to use the next branch Mar 26, 2024
@mnajdova
Copy link
Member Author

I don't have luck with this PR 😄 I am getting this error on the netlify build:

Screenshot 2024-03-26 at 15 24 14

Should I increase the --max_old_space_size? Maybe double the value, or is it too much? cc @Janpot

@Janpot
Copy link
Member

Janpot commented Mar 26, 2024

I don't think these are memory problems:

3:00:47 PM: Error occurred prerendering page "/versions". Read more: https://nextjs.org/docs/messages/prerender-error
3:00:47 PM: TypeError: fetch failed
3:00:47 PM:     at Object.fetch (node:internal/deps/undici/undici:11731:11)
3:00:47 PM:     at async I (/opt/build/repo/docs/.next/server/pages/versions.js:1:33399)
3:00:47 PM:     at async A.getInitialProps (/opt/build/repo/docs/.next/server/pages/versions.js:1:33726)
3:00:47 PM:     at async el.getInitialProps (/opt/build/repo/docs/.next/server/chunks/17098.js:152:173342)
3:00:47 PM:     at async s (/opt/build/repo/node_modules/.pnpm/next@13.5.1_@babel+core@7.24.3_babel-plugin-macros@3.1.0_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/compiled/next-server/pages.runtime.prod.js:1:32006)
3:00:47 PM:     at async Be (/opt/build/repo/node_modules/.pnpm/next@13.5.1_@babel+core@7.24.3_babel-plugin-macros@3.1.0_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/compiled/next-server/pages.runtime.prod.js:1:53734)
3:00:47 PM:     at async /opt/build/repo/node_modules/.pnpm/next@13.5.1_@babel+core@7.24.3_babel-plugin-macros@3.1.0_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/export/worker.js:487:36
3:00:47 PM:     at async Span.traceAsyncFn (/opt/build/repo/node_modules/.pnpm/next@13.5.1_@babel+core@7.24.3_babel-plugin-macros@3.1.0_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/trace/trace.js:105:20)
3:00:47 PM: > Export encountered errors on following paths:
3:00:47 PM: 	/versions

I think this line failed. I'm doing a retry, let's see if it passes.

edit: GitHub didn't report any incidents. Perhaps a shark bit a cable... 😄

@mnajdova
Copy link
Member Author

edit: GitHub didn't report any incidents. Perhaps a shark bit a cable... 😄

If one more thing happens today on this PR, I swear I am just going to close it and forget about it 😄 I tried retry few times too, didn't help.

@mnajdova
Copy link
Member Author

It passes on the release PR: #41665 I will do the release first and then deal with this.

@Janpot
Copy link
Member

Janpot commented Mar 26, 2024

Looks like the error returned by Next.js fetch implementation has a cause property with more details. They could print better error messages in production.

@mnajdova mnajdova merged commit 6249b99 into mui:next Mar 29, 2024
19 checks passed
tejasparkar pushed a commit to tejasparkar/material-ui that referenced this pull request Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants