Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][FilledInput] Convert to support CSS extraction #41663

Closed
wants to merge 7 commits into from
Closed

[material-ui][FilledInput] Convert to support CSS extraction #41663

wants to merge 7 commits into from

Conversation

mj12albert
Copy link
Member

@mj12albert mj12albert added the package: material-ui Specific to @mui/material label Mar 26, 2024
@mui-bot
Copy link

mui-bot commented Mar 26, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-41663--material-ui.netlify.app/

packages/material-ui/material-ui.production.min.js: parsed: +0.15% , gzip: +0.06%
TextField: parsed: +0.46% , gzip: +0.36%
FilledInput: parsed: +0.89% , gzip: +0.61%
@material-ui/core: parsed: +0.12% , gzip: +0.07%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 2661a30

@mj12albert
Copy link
Member Author

@siriwatknp At the "Render demos" step, I found that there is no docs/pages/material-ui/react-filled-input, only react-text-field

Would all the components that compose TextField need to be converted first to progress this? 🤔

@mj12albert mj12albert mentioned this pull request Mar 26, 2024
Closed
62 tasks
@siriwatknp
Copy link
Member

@siriwatknp At the "Render demos" step, I found that there is no docs/pages/material-ui/react-filled-input, only react-text-field

Would all the components that compose TextField need to be converted first to progress this? 🤔

No need, you can use the react-text-field and check if FilledInput styles has been converted to Pigment, that all. The rest of TextFields will be emotion which should work along side with Pigment

siriwatknp
siriwatknp reviewed Mar 28, 2024
View reviewed changes
packages/mui-material/src/FilledInput/FilledInput.js Outdated
},
},
],

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

siriwatknp
siriwatknp requested changes Mar 28, 2024
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comment.

siriwatknp
siriwatknp approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you for starting this. I pushed some fixes, will merge once the CIs are green.

@siriwatknp siriwatknp marked this pull request as ready for review April 25, 2024 09:48
@siriwatknp siriwatknp added component: text field This is the name of the generic UI component, not the React module! component: input This is the name of the generic UI component, not the React module! and removed component: text field This is the name of the generic UI component, not the React module! labels Apr 25, 2024
@siriwatknp siriwatknp enabled auto-merge (squash) April 25, 2024 09:49
@siriwatknp siriwatknp mentioned this pull request Apr 26, 2024
Open
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 17, 2024
@siriwatknp
Copy link
Member

This work has been done in another PR.

@siriwatknp siriwatknp closed this Jul 31, 2024
auto-merge was automatically disabled July 31, 2024 03:12

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
component: input This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mj12albert @mui-bot @siriwatknp