Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release] v5.15.16 #41915

Closed
wants to merge 3 commits into from
Closed

[release] v5.15.16 #41915

wants to merge 3 commits into from

Conversation

DiegoAndai
Copy link
Member

@DiegoAndai DiegoAndai commented Apr 15, 2024 •
edited
Loading

PR for release v5.15.16

@DiegoAndai DiegoAndai requested a review from a team April 15, 2024 19:02
@DiegoAndai DiegoAndai added the release We are shipping :D label Apr 15, 2024
@DiegoAndai DiegoAndai self-assigned this Apr 15, 2024
@mui-bot
Copy link

mui-bot commented Apr 15, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-41915--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 6f838e4

michaldudak
michaldudak reviewed Apr 15, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@danilo-leal
Copy link
Contributor

Can I get some help with cherry-picking to master these two Connect-related PRs? 😬 #41763 & #40848 — I was concerned to just them directly to material-ui-docs as I saw some cherry-pick PRs lately, so wasn't sure what was the best approach.

ZeeshanTamboli
ZeeshanTamboli reviewed Apr 16, 2024
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why wasn't PR #41905 for Joy UI picked up?

Edit: I probably shouldn't have cherry-picked it into master. I see that the next beta version of Joy UI will be released from v6.0.0-alpha.3 in #41916.

CHANGELOG.md
### `@mui/material@5.15.16`

- [Dialog] Prevent onClick on the root element from being overwritten (#41914) @ryanburr
- Fix import statement in migration guide (#41864) @sai6855
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in docs section.

@mnajdova
Copy link
Member

We are releasing only the stable packages for v5, as we would have conflicts with Joy UI, Base UI and the other alpha/beta packages. @siriwatknp volunteer will handle the v5 release, we can do it by the end of the week.

@DiegoAndai
Copy link
Member Author

Can I get some help with cherry-picking to master these two Connect-related PRs? 😬 #41763 & #40848

Sure, I'll create the cherry-pick PRs

We are releasing only the stable packages for v5, as we would have conflicts with Joy UI, Base UI and the other alpha/beta packages.

This is why I removed Joy, and only bumped the stable packages.

@siriwatknp volunteer will handle the v5 release, we can do it by the end of the week.

No problem. Should I close this PR? Will @siriwatknp be taking all v5 releases?

@siriwatknp
Copy link
Member

Can I get some help with cherry-picking to master these two Connect-related PRs? 😬 #41763 & #40848

Sure, I'll create the cherry-pick PRs

We are releasing only the stable packages for v5, as we would have conflicts with Joy UI, Base UI and the other alpha/beta packages.

This is why I removed Joy, and only bumped the stable packages.

@siriwatknp volunteer will handle the v5 release, we can do it by the end of the week.

No problem. Should I close this PR? Will @siriwatknp be taking all v5 releases?

Feel free to close this PR, I will handle v5 releases.

@DiegoAndai DiegoAndai closed this Apr 17, 2024
@DiegoAndai DiegoAndai deleted the v5.15.16 branch April 17, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak left review comments

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli left review comments

Assignees

@DiegoAndai DiegoAndai

Labels
release We are shipping :D
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@DiegoAndai @mui-bot @danilo-leal @mnajdova @siriwatknp @michaldudak @ZeeshanTamboli