-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Restrict import path with ESLint #41970
[core] Restrict import path with ESLint #41970
Conversation
Netlify deploy previewhttps://deploy-preview-41970--material-ui.netlify.app/ Bundle size report |
'@base_ui/*/*/*', | ||
// Allow any import depth with any internal packages | ||
'!@mui/internal-*/**', | ||
'!@mui/docs/**', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should rename this one to @mui/internal-docs
. @mui/docs
was exporting public packages, it's not the case anymore.
53fdf6b
to
7a8175d
Compare
I suspect that our move to the |
Oh yes, this will be great once we have package.json exports 🙌. We will need to fix the violations we have in the codebase to get there. I think rule will help us get there, e.g. If MUI X relies on private modules, best to caught it before we break them 😁 |
Yes, we decided to test more integrations before merging and we're running into a few issues. e.g. I suspect this one will be a blocker vercel/next.js#64796. |
A step to fix https://github.com/mui/mui-toolpad/pull/3417/files#r1572992179 at the root.
https://eslint.org/docs/latest/rules/no-restricted-imports