Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update pnpm order, move to second #42712

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

ahmadnadeem6236
Copy link
Contributor

@ahmadnadeem6236 ahmadnadeem6236 commented Jun 22, 2024

Closes mui/mui-public#181

  • material-ui/getting-started/installation/
  • base-ui/getting-started/quickstart/
  • joy-ui/getting-started/installation/
  • system/getting-started/installation/
change-pnpm-order.mp4

@danilo-leal danilo-leal changed the title Change pnpm order #42699 [docs] Put pnpm install commands as the second one Jun 24, 2024
@danilo-leal danilo-leal added the docs Improvements or additions to the documentation label Jun 24, 2024
@zannager zannager requested a review from mnajdova June 24, 2024 13:25
@aarongarciah aarongarciah requested review from aarongarciah and removed request for mnajdova July 1, 2024 11:24
Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ahmadnadeem6236, thanks. We're missing quite some places to update. If you search for <codeblock storageKey="package-manager"> you'll find them all. These are all the files we need to update:

  • docs/data/base/getting-started/quickstart/quickstart.md
  • docs/data/joy/customization/right-to-left/right-to-left.md
  • docs/data/joy/getting-started/installation/installation.md
  • docs/data/material/components/about-the-lab/about-the-lab.md
  • docs/data/material/components/icons/icons.md
  • docs/data/material/components/material-icons/material-icons.md
  • docs/data/material/components/typography/typography.md
  • docs/data/material/customization/right-to-left/right-to-left.md
  • docs/data/material/getting-started/installation/installation.md
  • docs/data/material/integrations/nextjs/nextjs.md
  • docs/data/material/migration/migration-v4/migration-v4.md
  • docs/data/system/getting-started/installation/installation.md
  • docs/pages/blog/introducing-base-ui.md
  • docs/pages/experiments/docs/codeblock.md

Let me know if you need any help.

@ZeeshanTamboli ZeeshanTamboli changed the title [docs] Put pnpm install commands as the second one [docs] Update pnpm order, move to second Aug 26, 2024
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahmadnadeem6236 I pushed the remaining changes. Thanks for the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Change pnpm order, place second
5 participants