Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mui-material][Breadcrumbs] Enable onClick to be an editable prop #42815

Closed
wants to merge 2 commits into from
Closed

[mui-material][Breadcrumbs] Enable onClick to be an editable prop #42815

wants to merge 2 commits into from

Conversation

duynguyen-kun
Copy link

@duynguyen-kun duynguyen-kun reopened this Jul 1, 2024
@duynguyen-kun duynguyen-kun mentioned this pull request Jul 1, 2024
Closed
ZeeshanTamboli
ZeeshanTamboli reviewed Jul 2, 2024
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the documentation. I think we should also add a demo for it.

packages/mui-material/src/Breadcrumbs/Breadcrumbs.js
@@ -152,7 +153,7 @@ const Breadcrumbs = React.forwardRef(function Breadcrumbs(inProps, ref) {
key="ellipsis"
slots={{ CollapsedIcon: slots.CollapsedIcon }}
slotProps={{ collapsedIcon: collapsedIconSlotProps }}
onClick={handleClickExpand}
onClick={collapsedIconSlotProps.onClick || handleClickExpand}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be either here or above on line 116 through additionalProps.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm keeping this line and removing the line on 116 instead. Thanks

packages/mui-material/src/Breadcrumbs/Breadcrumbs.js Show resolved Hide resolved
@ZeeshanTamboli ZeeshanTamboli added new feature New feature or request component: breadcrumbs This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Jul 2, 2024
@ZeeshanTamboli
Copy link
Member

Since this PR isn't active, I am closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli left review comments

Assignees
No one assigned
Labels
component: breadcrumbs This is the name of the generic UI component, not the React module! new feature New feature or request package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duynguyen-kun @ZeeshanTamboli