Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui] Bring back GridProps and GridTypeMap #43717

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

DiegoAndai
Copy link
Member

@DiegoAndai DiegoAndai commented Sep 11, 2024

Fixes #43686.

This was an oversight of #43054. This only brings back the types requested in the issue, as there are some naming conflicts between the Grid and Grid2 other types exports (GridDirection, GridSpacing, GridWrap and GridSize), so adding those back would be opening a bigger can of worms. Hopefully, no one is using them, but if someone is and opens an issue, we can discuss possible solutions then.

@DiegoAndai DiegoAndai self-assigned this Sep 11, 2024
@DiegoAndai DiegoAndai added typescript package: material-ui Specific to @mui/material labels Sep 11, 2024
@mui-bot
Copy link

mui-bot commented Sep 11, 2024

Netlify deploy preview

https://deploy-preview-43717--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against a140ce9

@DiegoAndai DiegoAndai merged commit 40c7199 into mui:master Sep 13, 2024
21 of 22 checks passed
@DiegoAndai DiegoAndai deleted the recover-grid-missing-types branch September 13, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: material-ui Specific to @mui/material typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[material-ui] v6 does not export GridProps and GridMapType
4 participants