[Grid2] Add removal of item prop to grid-v2-props codemod #43794

sai6855 · 2024-09-17T10:21:11Z

closes #43621

I have followed (at least) the PR section of the contributing guide.

mui-bot · 2024-09-17T10:24:09Z

Netlify deploy preview

https://deploy-preview-43794--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 24e88d6

sai6855 · 2024-09-17T11:12:31Z

packages/mui-codemod/src/v6.0.0/grid-v2-props/grid-v2-props.js

@@ -192,6 +192,16 @@ export default function gridV2Props(file, api, options) {
      el.node.openingElement.attributes = el.node.openingElement.attributes.filter(
        (attr) => !attributesToPrune.includes(attr),
      );
+
+      const itemProp = el.node.openingElement.attributes.find(


Implementation taken from

material-ui/packages/mui-codemod/src/deprecations/divider-props/divider-props.js

Lines 16 to 29 in 15428ca

const lightProp = elementPath.node.openingElement.attributes.find(

(attr) => attr.type === 'JSXAttribute' && attr.name.name === 'light',

);

if (!lightProp) {

return;

}

elementPath.node.openingElement.attributes = elementPath.node.openingElement.attributes.filter(

(attr) => {

if (attr.type === 'JSXAttribute' && attr.name.name === 'light') {

return false;

}

return true;

aarongarciah

Nice!

Add removal to item prop to grid codemod

9df5de9

sai6855 marked this pull request as draft September 17, 2024 10:21

sai6855 added bug 🐛 Something doesn't work component: Grid The React component. package: material-ui Specific to @mui/material package: codemod Specific to @mui/codemod labels Sep 17, 2024

Update grid-v2-props.js

24e88d6

sai6855 changed the title ~~[Grid2] Add removal to item prop to grid codemod~~ [Grid2] Add removal to item prop to grid-v2-props codemod Sep 17, 2024

sai6855 marked this pull request as ready for review September 17, 2024 10:32

sai6855 requested a review from aarongarciah September 17, 2024 10:43

sai6855 changed the title ~~[Grid2] Add removal to item prop to grid-v2-props codemod~~ [Grid2] Add removal of item prop to grid-v2-props codemod Sep 17, 2024

sai6855 commented Sep 17, 2024

View reviewed changes

aarongarciah approved these changes Sep 17, 2024

View reviewed changes

aarongarciah merged commit 52b99cd into mui:master Sep 17, 2024
19 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Grid2] Add removal of item prop to grid-v2-props codemod #43794

[Grid2] Add removal of item prop to grid-v2-props codemod #43794

sai6855 commented Sep 17, 2024

mui-bot commented Sep 17, 2024 •

edited

Loading

sai6855 Sep 17, 2024

aarongarciah left a comment

	const lightProp = elementPath.node.openingElement.attributes.find(
	(attr) => attr.type === 'JSXAttribute' && attr.name.name === 'light',
	);

	if (!lightProp) {
	return;
	}

	elementPath.node.openingElement.attributes = elementPath.node.openingElement.attributes.filter(
	(attr) => {
	if (attr.type === 'JSXAttribute' && attr.name.name === 'light') {
	return false;
	}
	return true;

[Grid2] Add removal of item prop to grid-v2-props codemod #43794

[Grid2] Add removal of item prop to grid-v2-props codemod #43794

Conversation

sai6855 commented Sep 17, 2024

mui-bot commented Sep 17, 2024 • edited Loading

Netlify deploy preview

Bundle size report

sai6855 Sep 17, 2024

Choose a reason for hiding this comment

aarongarciah left a comment

Choose a reason for hiding this comment

mui-bot commented Sep 17, 2024 •

edited

Loading