Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize UI components: Toggle. #855

Merged
merged 1 commit into from
Jun 16, 2015

Conversation

misha-panyushkin
Copy link
Contributor

This update targeted on UI components customization with developers styles.

@hai-cea
Copy link
Member

hai-cea commented Jun 15, 2015

@misha-panyushkin Looks like this PR made the track too long?

This PR:
fireshot capture - material ui - http___localhost_3000_ _components_switches

Current on material-ui.com
fireshot capture - material ui - material design rea_ - http___material-ui com_ _components_switches

@misha-panyushkin
Copy link
Contributor Author

@hai-cea you're right. Restore default toggle element width in the latest commit.

@@ -13,7 +13,7 @@ var Toggle = React.createClass({
},

propTypes: {
elementStyle: React.PropTypes.object,
toggleElementBoxStyle: React.PropTypes.object,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prop rename will introduce a breaking change. Can we keep as is for now pls?

@hai-cea
Copy link
Member

hai-cea commented Jun 15, 2015

Also, please squash down to 1 commit. Thanks!

@misha-panyushkin
Copy link
Contributor Author

@hai-cea sure, I'll make the PR changes tomorrow morning.

- customize toggle element width along with track width;
- update thumb switched on/off position styles with more flexible ones;
- customize toggle ripple styles;
- restore default toggle element width;
- restore breaking change in namespacing.
@misha-panyushkin
Copy link
Contributor Author

@hai-cea done.

@hai-cea
Copy link
Member

hai-cea commented Jun 16, 2015

Thanks @misha-panyushkin

hai-cea added a commit that referenced this pull request Jun 16, 2015
@hai-cea hai-cea merged commit 239ad0c into mui:master Jun 16, 2015
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Nov 10, 2020
* Migrate from classnames to nicer clsx

* Update size snapshot
@zannager zannager added the component: toggle button This is the name of the generic UI component, not the React module! label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: toggle button This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants