Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed username trim removes information after dot #1172

Merged
merged 3 commits into from
May 14, 2024
Merged

Fixed username trim removes information after dot #1172

merged 3 commits into from
May 14, 2024

Conversation

razvantomegea
Copy link
Contributor

@razvantomegea razvantomegea commented May 14, 2024 •
edited
Loading

Issue

Username that does not end with .elrond loses information

Fix

Trim only the usernames that end with .elrond, not all which contain .

Contains breaking changes

[x] No

[] Yes

Updated CHANGELOG

[x] Yes

Testing

[x] User testing
[] Unit tests

@razvantomegea razvantomegea deleted the rt/improvements/account-assets branch May 14, 2024 06:58
@razvantomegea razvantomegea reopened this May 14, 2024
@razvantomegea razvantomegea changed the title Added assets information in get account API call Fixed username trim removes information after dot May 14, 2024
@razvantomegea razvantomegea merged commit 5178825 into development May 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreigiura andreigiura andreigiura approved these changes

@radumojic radumojic radumojic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@razvantomegea @andreigiura @radumojic