Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed walletconnect infinite loading and wallet redirect when using custom network config #1180

Merged
merged 2 commits into from
May 30, 2024

Conversation

razvantomegea
Copy link
Contributor

@razvantomegea razvantomegea commented May 30, 2024

Issues

  • infinite loading when using custom network config;
  • redirect to wallet address login hook after logout when using custom network config.

Reproduce

Actual result: Infinite loading on wallet connect and user is redirected to https://wallet.voyager1.dev/hook/login
Expected result: wallet connect is loaded successfully and the user can relogin into the wallet without any other redirects

Root cause

  • invalid chainId is set when using different chain ID then mainnet, testnet, and devnet;
  • wallet provider is set instead of wallet connect provider. Wallet provider attempts login.

Contains breaking changes

[x] No

[] Yes

Updated CHANGELOG

[x] Yes

Testing

[x] User testing
[] Unit tests

@razvantomegea razvantomegea merged commit a2a3b70 into development May 30, 2024
1 check passed
@razvantomegea razvantomegea deleted the rt/fix/walletconnect-custom-network branch May 30, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants