Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toast for cancel sign message does not show #995

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

mgavrila
Copy link
Collaborator

@mgavrila mgavrila commented Dec 18, 2023

Issue

Cancelling a sign message does not display a toast with a specified message.

Reproduce

Issue exists on version 2.25.2 of sdk-dapp.

Root cause

Sign message URL params does not contain signSession in order for useParseSignedTransactions to be able to intercept and display the message.

Fix

Instead of adding a new param for the URL, use directly setSignTransactionsCancelMessage in order to display the errorMessage.

Additional changes

Contains breaking changes

[x] No

[] Yes

Updated CHANGELOG

[x] Yes

Testing

[x] User testing
[] Unit tests

@mgavrila mgavrila changed the base branch from main to development December 18, 2023 15:05
CHANGELOG.md Outdated Show resolved Hide resolved
@mgavrila mgavrila merged commit c85d7e0 into development Dec 18, 2023
@mgavrila mgavrila deleted the amg/bugfix/cancel-sign-message branch December 18, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants