Default NFT Balance #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
previously approved these changes
Jul 12, 2023
| run: npm run compile | ||
| - name: Run Unit Tests | ||
| run: | | ||
| npm run test |
| @@ -61,7 +61,7 @@ export interface INetworkProvider { | |||
| /** | |||
| * Fetches the state of a transaction. | |||
| */ | |||
| getTransaction(txHash: string): Promise<TransactionOnNetwork>; | |||
| getTransaction(txHash: string, withProcessStatus?: boolean): Promise<TransactionOnNetwork>; | |||
There was a problem hiding this comment.
I forgot that we have this interface in the package. In my opinion it should be removed (breaking change) - in a separate PR.
There was a problem hiding this comment.
Will keep it in mind, this will be changed once the specs for sdk-network-providers are out.
| assert.equal(apiResponse.RoundAtEpochStart, proxyResponse.RoundAtEpochStart); | ||
| assert.equal(apiResponse.RoundsPerEpoch, proxyResponse.RoundsPerEpoch); | ||
| // done this way because the nonces may change until both requests are executed | ||
| assert.approximately(apiResponse.HighestFinalNonce, proxyResponse.HighestFinalNonce, 1); |
CiprianDraghici
approved these changes
Jul 13, 2023
andreibancioiu
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NFT Token balance set as
1if nobalancefield provided.Also, added the
tests-devnetto run as a github action and fixed the tests.