Execute ops #18
on_pull_request_build_contracts.yml
on: pull_request
build
/
build
1m 17s
Annotations
1 error and 9 warnings
build / build
Process completed with exit code 1.
|
[clippy] common/transaction/src/lib.rs#L86:
common/transaction/src/lib.rs#L86
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
--> common/transaction/src/lib.rs:86:1
|
86 | impl<M: ManagedTypeApi> Into<EsdtTokenData<M>> for StolenFromFrameworkEsdtTokenData<M> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see
https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
= note: `#[warn(clippy::from_over_into)]` on by default
help: replace the `Into` implementation with `From<StolenFromFrameworkEsdtTokenData<M>>`
|
86 ~ impl<M: ManagedTypeApi> From<StolenFromFrameworkEsdtTokenData<M>> for EsdtTokenData<M> {
87 ~ fn from(val: StolenFromFrameworkEsdtTokenData<M>) -> Self {
88 | EsdtTokenData {
89 ~ token_type: val.token_type,
90 ~ amount: val.amount,
91 ~ frozen: val.frozen,
92 ~ hash: val.hash,
93 ~ name: val.name,
94 ~ attributes: val.attributes,
95 ~ creator: val.creator,
96 ~ royalties: val.royalties,
97 ~ uris: val.uris,
|
|
[clippy] common/transaction/src/lib.rs#L128:
common/transaction/src/lib.rs#L128
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
--> common/transaction/src/lib.rs:128:1
|
128 | impl<M: ManagedTypeApi> Into<EsdtTokenPayment<M>> for OperationEsdtPayment<M> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see
https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
help: replace the `Into` implementation with `From<OperationEsdtPayment<M>>`
|
128 ~ impl<M: ManagedTypeApi> From<OperationEsdtPayment<M>> for EsdtTokenPayment<M> {
129 ~ fn from(val: OperationEsdtPayment<M>) -> Self {
130 ~ EsdtTokenPayment { token_identifier: val.token_identifier, token_nonce: val.token_nonce, amount: val.token_data.amount }
|
|
[clippy] common/transaction/src/lib.rs#L86:
common/transaction/src/lib.rs#L86
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
--> common/transaction/src/lib.rs:86:1
|
86 | impl<M: ManagedTypeApi> Into<EsdtTokenData<M>> for StolenFromFrameworkEsdtTokenData<M> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see
https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
= note: `#[warn(clippy::from_over_into)]` on by default
help: replace the `Into` implementation with `From<StolenFromFrameworkEsdtTokenData<M>>`
|
86 ~ impl<M: ManagedTypeApi> From<StolenFromFrameworkEsdtTokenData<M>> for EsdtTokenData<M> {
87 ~ fn from(val: StolenFromFrameworkEsdtTokenData<M>) -> Self {
88 | EsdtTokenData {
89 ~ token_type: val.token_type,
90 ~ amount: val.amount,
91 ~ frozen: val.frozen,
92 ~ hash: val.hash,
93 ~ name: val.name,
94 ~ attributes: val.attributes,
95 ~ creator: val.creator,
96 ~ royalties: val.royalties,
97 ~ uris: val.uris,
|
|
[clippy] common/transaction/src/lib.rs#L128:
common/transaction/src/lib.rs#L128
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
--> common/transaction/src/lib.rs:128:1
|
128 | impl<M: ManagedTypeApi> Into<EsdtTokenPayment<M>> for OperationEsdtPayment<M> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see
https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
help: replace the `Into` implementation with `From<OperationEsdtPayment<M>>`
|
128 ~ impl<M: ManagedTypeApi> From<OperationEsdtPayment<M>> for EsdtTokenPayment<M> {
129 ~ fn from(val: OperationEsdtPayment<M>) -> Self {
130 ~ EsdtTokenPayment { token_identifier: val.token_identifier, token_nonce: val.token_nonce, amount: val.token_data.amount }
|
|
[clippy] esdt-safe/src/from_sovereign/token_mapping.rs#L25:
esdt-safe/src/from_sovereign/token_mapping.rs#L25
warning: this creates an owned instance just for comparison
--> esdt-safe/src/from_sovereign/token_mapping.rs:25:27
|
25 | issue_cost == BigUint::from(DEFAULT_ISSUE_COST),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `DEFAULT_ISSUE_COST`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
= note: `#[warn(clippy::cmp_owned)]` on by default
|
[clippy] esdt-safe/src/from_sovereign/token_mapping.rs#L25:
esdt-safe/src/from_sovereign/token_mapping.rs#L25
warning: this creates an owned instance just for comparison
--> esdt-safe/src/from_sovereign/token_mapping.rs:25:27
|
25 | issue_cost == BigUint::from(DEFAULT_ISSUE_COST),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `DEFAULT_ISSUE_COST`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
= note: `#[warn(clippy::cmp_owned)]` on by default
|
[clippy] esdt-safe/src/to_sovereign/create_tx.rs#L177:
esdt-safe/src/to_sovereign/create_tx.rs#L177
warning: length comparison to zero
--> esdt-safe/src/to_sovereign/create_tx.rs:177:16
|
177 | if self.token_whitelist().len() > 0
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.token_whitelist().is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
= note: `#[warn(clippy::len_zero)]` on by default
|
[clippy] esdt-safe/src/to_sovereign/create_tx.rs#L177:
esdt-safe/src/to_sovereign/create_tx.rs#L177
warning: length comparison to zero
--> esdt-safe/src/to_sovereign/create_tx.rs:177:16
|
177 | if self.token_whitelist().len() > 0
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.token_whitelist().is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
= note: `#[warn(clippy::len_zero)]` on by default
|
build / build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|