Wegld fee #65
Wegld fee #65
Conversation
andreiblt1304
commented
Jun 28, 2024
•
andreiblt1304
commented
- Created a separate endpoint to register tokens
- Added registered tokens mapper
- Modified init endpoint with optional values for WEGLD and Sovereign Token Prefix Identifiers
Now the verification consists only if the tokens has the current's sovereign prefix and if they are registered. The WEGLD fee has to be paid before execution.
common/utils/src/lib.rs
Outdated
| return false; | ||
| } | ||
|
|
||
| let dash = b'-'; |
There was a problem hiding this comment.
Have this as a const instead.
common/utils/src/lib.rs
Outdated
|
|
||
| let dash = b'-'; | ||
| let buffer = token_id.as_managed_buffer(); | ||
| let mut array_buffer = [0u8; 32]; |
There was a problem hiding this comment.
"32" can also be a const, like "MAX_TOKEN_ID_LEN"
There was a problem hiding this comment.
Should also do the same in the above function btw.
| ); | ||
|
|
||
| for token_id in tokens { | ||
| self.register_token(token_id); |
There was a problem hiding this comment.
If this makes token issue, it won't work. You can only make one legacy async call per call, which is what the token issue framework uses.
There was a problem hiding this comment.
register_token just saves the TokenIdentifier to the paid_issued_tokens mapper
enshrine-esdt-safe/src/lib.rs
Outdated
| if !is_sovereign_chain { | ||
| match wegld_identifier { | ||
| Some(identifier) => { | ||
| require!( | ||
| identifier.is_valid_esdt_identifier(), | ||
| "Sent Identifier is not valid" | ||
| ); | ||
|
|
||
| self.wegld_identifier().set(identifier); | ||
| } | ||
|
|
||
| None => sc_panic!("WEGLG identifier must be set in Mainchain"), | ||
| } | ||
|
|
||
| match sov_token_prefix { | ||
| Some(prefix) => self.sovereign_tokens_prefix().set(prefix), | ||
| None => sc_panic!("Sovereign Token Prefix must be set in Mainchain"), | ||
| } | ||
| } |
There was a problem hiding this comment.
Can revert condition here to do some de-nesting, i.e.
if is_sovereign_chain {
return;
}
// code that was inside if
Also, since you need "Some" for both Option, why not take "TokenIdentifier" and "ManagedBuffer" directly in the init call?
There was a problem hiding this comment.
i agree with the de-nesting but I don't quite understand what you mean by taking those directly in the init call
