Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 128-bit integers (i128 and u128) #124

Merged
merged 2 commits into from
Apr 10, 2020
Merged

feat: add 128-bit integers (i128 and u128) #124

merged 2 commits into from
Apr 10, 2020

Conversation

wackbyte
Copy link
Contributor

Also includes Runtime::invoke_fn15 and a corresponding extra branch to invoke_fn!.

@wackbyte
Copy link
Contributor Author

Did I miss anything this time?

Copy link
Collaborator

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one small change.

crates/mun_hir/src/builtin_type.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 10, 2020

Codecov Report

Merging #124 into master will decrease coverage by 0.04%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
- Coverage   78.86%   78.81%   -0.05%     
==========================================
  Files         141      141              
  Lines        8728     8739      +11     
==========================================
+ Hits         6883     6888       +5     
- Misses       1845     1851       +6     
Impacted Files Coverage Δ
crates/mun_codegen/src/ir.rs 43.18% <ø> (ø)
crates/mun_codegen/src/test.rs 97.36% <ø> (ø)
crates/mun_codegen/src/type_info.rs 62.06% <ø> (ø)
crates/mun_hir/src/builtin_type.rs 0.00% <0.00%> (ø)
crates/mun_hir/src/name.rs 70.96% <ø> (ø)
crates/mun_hir/src/ty/tests.rs 96.05% <ø> (ø)
crates/mun_runtime/src/macros.rs 64.91% <ø> (ø)
crates/mun_runtime/src/reflection.rs 55.31% <ø> (ø)
crates/mun_hir/src/ty/primitives.rs 68.00% <50.00%> (-1.57%) ⬇️
crates/mun_codegen/src/ir/ty.rs 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8191f0...770b143. Read the comment docs.

@baszalmstra baszalmstra merged commit 36b9809 into mun-lang:master Apr 10, 2020
@wackbyte wackbyte deleted the 128-bit-integers branch April 12, 2020 22:19
@Wodann Wodann changed the title 128-bit integers i128 and u128 feat: add 128-bit integers (i128 and u128) May 2, 2020
@Wodann Wodann added this to the Mun v0.2 milestone May 14, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants