Merge pull request #15 from bfred-it/patch-1

Don't show errors outside console
musically-ut · Mar 3, 2016 · 9a36494 · 9a36494
2 parents 655d072 + e30cbef
commit 9a36494
Showing 1 changed file with 0 additions and 6 deletions.
diff --git a/app/data/contentscript.js b/app/data/contentscript.js
@@ -186,10 +186,6 @@ function showDetails(fullName, url, numStars,
     };
 }
 
-function showError(text) {
-    text.appendChild(document.createTextNode('no information'));
-}
-
 function makeRemoteDataURL(user, repo) {
     return 'https://api.github.com/repos/' +
                   user + '/' + repo + '/forks?sort=stargazers';
@@ -326,11 +322,9 @@ function onreadystateChangeFactory(xhr, successFn) {
             } else if (xhr.status === 403) {
                 console.warn(_logName,
                              'Looks like the rate-limit was exceeded.');
-                safeUpdateDOM(showError, 'rate limit exceeded');
             } else {
                 console.warn(_logName,
                              'Github API returned status:', xhr.status);
-                safeUpdateDOM(showError, 'showing error');
             }
         } else {
             // Request is still in progress