-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fork is not more recent #13
Comments
Interesting. Thanks for bringing this example to my notice. I will investigate it. |
instead of using the last 'committed_at' time. This is because we use the 'pushed_time' of the fork to determine if the fork is newer than the current repository. This should address #13.j
It turns out that the At the moment, I take the fork's The alternate is to get commits for both the source and the destination repository which would take the API call count from 2 to 3 per repo. I would be more comfortable going that route when I allow users to authenticate via the options page to avoid rate-limiting. To address it, I will add a "may" in the explanation for the flame icon and keep this issue open, in case Github clarifies the meanings or I add authentication. |
It looks like you want the Source (cahnory)
Fork (behnam)
Fork (unwelt)
So it looks like the "unwelt" branch has more recent updates, but no stars. Looking at the network graph, it's obvious that unwelt has the most updates. I don't even see behnam's fork there. So I'm guessing the I wonder if we need two different labels for forks:
|
Thanks for investigating it. :) Yes, However, during testing, I figured out that it doesn't work for other repositories. For example, for jaz303/tipsy, which is an example in the README, we see the following:
And for the best fork CloCkWeRX/tipsy, we see the following:
Here, the I asked I |
With Ivan's input, I have switched to an heuristic based on Compare API. I am testing it locally and hope to release it to Chrome store/Firefox addons soon. |
@Mottie I released the extension(s) earlier today. The Chrome extension update is live while the Firefox addon will take a while to get a preliminary review and then some to get to the users. Could you close the issue after confirming that it works? Thanks! |
It's looking good! Thanks for all your hard work! |
I found an example where a flame icon is added to a fork which appears to be exactly the same as the source...
Source: https://github.com/cahnory/jQuery.keyboard
Flamey Fork: https://github.com/behnam/jQuery.keyboard
There are only 2 commits in each repo.
The text was updated successfully, but these errors were encountered: