Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Safari 12+ extension #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ShotSkydiver
Copy link

So this is a new Safari 12+ extension that I've built, I've got it running in my Safari 14 beta and it works perfectly!

Copy link
Owner

@musically-ut musically-ut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks!

I will check it out locally. Could you include instructions about how to test it out locally? Then I will try to see how we can avoid copying the content script files over.

Thanks!

@ShotSkydiver
Copy link
Author

Oh, right! to test it locally, all you need to do is open the xcodeproj file in Xcode, then simply Run the Lovely forks scheme, and then open Safari, go to the Develop menu, and check "Allow unsigned extensions", then finally, go to the Extensions tab in Safari preferences, and enable the Lovely forks extension!

Screen Shot 2020-07-23 at 2 11 48 PM

@musically-ut
Copy link
Owner

Hmm, getting the XCode setup is taking a bit longer than I had hoped for and I have a busy few days coming up.

I think I'll pick this up in the middle of next week.

@musically-ut
Copy link
Owner

I'm happy to report that I do have my XCode setup correctly now (I think).

However, I'm giving #53 more priority. I'll keep this PR open and keep you posted.

@musically-ut
Copy link
Owner

Any hints before I dig in any deeper:

grafik

?

@ShotSkydiver
Copy link
Author

Hmm... it looks like you'll have to be on the macOS Big Sur beta to build this, I didn't realize that the SFExtensionMessageKey was a new property included in Big Sur: https://developer.apple.com/documentation/safariservices/sfextensionmessagekey

@ShotSkydiver
Copy link
Author

just FYI, since Big Sur has been publicly released, this should be feasible for anyone to build using the publicly available Xcode 12.2

@musically-ut
Copy link
Owner

Now that I have some time and the first minor version update to Big Sur has been released, I'm finally ready to upgrade.

I'll keep you posted; I'll need to dig a bit deeper into how to reconcile the code-base together instead of having to replicate the fixes in the core extension in three places separately (i.e. Userscript + Safari extension).

@astrowonk
Copy link

@ShotSkydiver I have tried converting several extensions including this one on Big Sur 11.1 and Xcode 12.3; they just won't show up in Safari's extension list even with the 'unsigned' turned on.

They do/did show up in "Safari Technology Preview." Have you had luck running the converted extension on 11.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants