Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: css animation forwards causing UI lag #973

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

luwes
Copy link
Contributor

@luwes luwes commented Aug 5, 2024

when turning off hardware acceleration on Chrome it was reported that the Mux player UI became laggy.

I found one other user on Stackoverflow with the same issue:
https://stackoverflow.com/questions/12991164/maintaining-the-final-state-at-end-of-a-css-animation#comment118487774_12991203

Seems like part of the explanation is found here
https://developer.mozilla.org/en-US/docs/Web/CSS/animation-fill-mode#forwards

Animated properties behave as if included in a set will-change property value. If a new stacking context was created during the animation, the target element retains the stacking context after the animation has finished.

@luwes luwes self-assigned this Aug 5, 2024
@luwes luwes requested a review from a team as a code owner August 5, 2024 22:54
Copy link

vercel bot commented Aug 5, 2024

@luwes is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Aug 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
elements-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2024 11:13pm
elements-demo-vanilla ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2024 11:13pm

@luwes luwes merged commit ec59cb3 into muxinc:main Aug 6, 2024
8 of 11 checks passed
@luwes luwes deleted the fix-ui-lag-bug branch August 6, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants