Support for HTTPS TLS connections on older devices #332
Conversation
…TPS connection on selected SDK versions
…d in Facebook React library (PR 9480)
|
I adapted the implementation to somewhat match the one included in Facebook React, that is based on the same source but i think it's more polished and enables support also for TLS 1.1. Bonus: If they find some bug it will be easier to merge the fixes. |
| package com.google.android.apps.muzei; | ||
|
|
||
| /** | ||
| * Created by marcopar on 11/02/17. |
There was a problem hiding this comment.
Add the copyright/licensing block please
| package com.google.android.apps.muzei; | ||
|
|
||
| /** | ||
| * Created by marcopar on 11/02/17. |
There was a problem hiding this comment.
Remove this comment block
| @@ -0,0 +1,105 @@ | |||
| package com.google.android.apps.muzei; | |||
There was a problem hiding this comment.
Add the copyright/licensing block please
| /** | ||
| * Factory for OkHttpClient, supports the creation of clients enabling TLS on devices where it's not enabled by default (mainly pre lollipop) | ||
| */ | ||
|
|
There was a problem hiding this comment.
Remove this extra line
|
|
||
| return client; | ||
| } | ||
|
|
There was a problem hiding this comment.
Remove extra lines
| * True if enabling TLS is needed on current device (SDK version >= 16 and < 22) | ||
| */ | ||
| public static boolean isTLSEnableNeeded() { | ||
| if (Build.VERSION.SDK_INT >= 16 && Build.VERSION.SDK_INT < 22) { |
There was a problem hiding this comment.
Please use the Build.VERSION_CODES constants
|
Request changes pushed. |
|
Thanks for your contribution! |
Devices with SDK version between 16 and 20 (and even some on 21) support TLS but TLS is not enabled by default.
Many websites are switching to HTTPS requiring the use of TLS (i.e. NASA sites)
This patch adds a factory for creating OkHttpClient with TLS enabled on those SDK versions.
It then modifies DownloadArtTask so it uses that factory.
Without this patch Muzei fails to download images from those websites on those devices because with TLS disabled the SSL handshake fails.
Background:
For example it fails to download images using my muzei source that fetches images from the NASA / SDO project website that switched to TLS at the end of 2016.
https://github.com/marcopar/SDOViewer
It is possible to reproduce the problem running Muzei and my source on a API19 emulator instance.
This patch has been built following the indications on this OkHttp tracker:
square/okhttp#2372
As you can see the issue is referred by several other trackers recognizing the problem.