fix: ip function error "[object Object]" #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
由于云函数 "ip" 中 hasCatch 是 await cache.get(ip); 属于一个对象，而下面直接对这个对象用了 JSON.parse，然后会报错 "message": "Function 执行报错: \"[object Object]\" is not valid JSON" 所以需要加一个判断，确保他是一个字符串 Signed-off-by: BLxcwg666 <huixcwg@gmail.com>
|
hi @BLxcwg666. 我想知道这是在哪里出现的这个报错😂 |
要是云函数里面配置了没修复的那个，你点开后台的评论管理里面，鼠标悬浮到ip上面，能查出来，你刷新一下，悬浮到同一个ip上面，就报错了，如果没复现需要我录视频复现一下吗 @wibus-wee |
或者你直接 curl https://后端域名/api/v2/fn/built-in/ip?ip=114.51.45.14 |
|
我这里无法复现这个问题😂 你能否提供一下出现报错问题时 hasCatch 的值？谢谢🙏 |
wibus-wee
requested changes
Jan 20, 2024
你去仪表盘下拉清除一下 API 缓存 和 数据缓存，然后 curl 就能复现 至于两您说的问题是因为我是基于3天前默认的built-in的ip函数的基础上改的，可能对于现在来说有点出入 |
|
我看了一下 Core 的代码，好像...已经parse了啊😂 |
|
不用了，我看到问题了哈哈哈 谢谢 |
Signed-off-by: BLxcwg666 <huixcwg@gmail.com>
|
已经改了，如果没问题可以合一下 pr 吗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
由于云函数 "ip" 中
hasCatch是await cache.get(ip);属于一个对象，而下面直接对这个对象用了
JSON.parse，然后会报错"message": "Function 执行报错: \"[object Object]\" is not valid JSON"所以需要加一个判断，确保他是一个字符串，如果不是就转一下
Linked Issues
None
Additional context
None