Skip to content

Commit

Permalink
review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
mxschmitt committed Apr 9, 2024
1 parent 956cfad commit 9e3cca4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions docs/src/release-notes-csharp.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ toc_max_heading_level: 2
await Context.ClearCookiesAsync(new() { Domain = "my-origin.com" });
```

- New method [`method: Locator.contentFrame`] converts a [Locator] object to a [FrameLocator]. This can be useful when you have a [Locator] object obtained somewhere, and later on would like to interact with the content inside the frame.
- New property [`method: Locator.contentFrame`] converts a [Locator] object to a [FrameLocator]. This can be useful when you have a [Locator] object obtained somewhere, and later on would like to interact with the content inside the frame.

```csharp
var locator = Page.Locator("iframe[name='embedded']");
Expand All @@ -28,7 +28,7 @@ toc_max_heading_level: 2
await frameLocator.GetByRole(AriaRole.Button).ClickAsync();
```

- New method [`method: FrameLocator.owner`] converts a [FrameLocator] object to a [Locator]. This can be useful when you have a [FrameLocator] object obtained somewhere, and later on would like to interact with the `iframe` element.
- New property [`method: FrameLocator.owner`] converts a [FrameLocator] object to a [Locator]. This can be useful when you have a [FrameLocator] object obtained somewhere, and later on would like to interact with the `iframe` element.

```csharp
var frameLocator = page.FrameLocator("iframe[name='embedded']");
Expand Down
4 changes: 2 additions & 2 deletions docs/src/release-notes-java.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ toc_max_heading_level: 2
- New method [`method: FrameLocator.owner`] converts a [FrameLocator] object to a [Locator]. This can be useful when you have a [FrameLocator] object obtained somewhere, and later on would like to interact with the `iframe` element.

```java
FrameLocator frameLocator = page.frameLocator("iframe[name='embedded']")
FrameLocator frameLocator = page.frameLocator("iframe[name='embedded']");
// ...
Locator locator = frameLocator.owner()
Locator locator = frameLocator.owner();
assertThat(locator).isVisible();
```

Expand Down

0 comments on commit 9e3cca4

Please sign in to comment.